ci: run the floors job on pull requests and drop the release floors gate - #257
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings lite-bootstrap in line with section 7 of the standard (modern-python/.github#113). The floors job now gates every pull request and push to main, and is skipped on the schedule.
_checks.yml: remove thelowest-directinput, rename the job tofloors(Four repos run the dependency-floor gate under a name the standard does not use .github#111), and guard it withif: github.event_name != 'schedule'.scheduled.yml: stop passing the input.release.yml: removefloors-gateand.github/scripts/require-floor-run.sh. That gate existed only because floors never ran on pull requests (A floor break can merge with every check green:lowest-directnever runs on pull requests #245). Now that floors runs on every PR and push to main, release.yml matches the other repos, with no in-workflow gate.report-scheduled-failure.sh: remove the hint for a floors failure, since the scheduled run no longer includes that job.The input's rationale was that an upstream release could turn a PR red for reasons the PR didn't cause. The standard answers that:
pytestalready resolves fresh on every run, so pull requests already carry that exposure.Not in this PR: wheel-only (#254). With
--no-buildor--only-binary,lowest-directquietly climbs past a floor that has no wheel instead of failing. So a flag alone would trade the slow sdist build on the (3.14, free) leg for a false green. That will be handled org-wide, together with a check that each resolved version equals its declared floor.