Repository navigation
Fix quote music ducking, theme startup, and admin number editing - #22
Merged
Merged
Conversation
…ix numeric drafts
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quotes now lower the continuously looping theme to 20% of its configured level and restore it when playback ends or is canceled. With the default theme level, this is 75% → 15% → 75%, using a 150 ms reduction and 800 ms restoration. Theme mute takes priority throughout; the music source never restarts.
Theme startup no longer waits for the settings API. The document preloads the theme, and the mixer starts in parallel with fetching shared settings, using defaults until the saved settings arrive. Browser autoplay restrictions can still require a first tap or keypress.
The audio admin number fields now preserve editable string drafts instead of coercing an empty field to zero on each keystroke. Both fields can be cleared and retyped, including a zero or fractional fade duration. Save validates required values and ranges before sending numeric API values. The other admin numeric handlers already used string drafts; regression tests now cover collection fields (bounty, points, year) and clearing a repository's zero pin position.
Validation:
Follow-up to merged #21.
Commit: a569c24.
Vercel preview for this commit: READY — https://bikram-n0w6lejpg-modhack2003s-projects.vercel.app .