Skip to content

Fix quote music ducking, theme startup, and admin number editing - #22

Merged
modhack2003 merged 2 commits into
mainfrom
fix/audio-startup-ducking-admin-inputs
Oct 16, 2026
Merged

modhack2003 merged 2 commits into
mainfrom
fix/audio-startup-ducking-admin-inputs

Conversation

@modhack2003

@modhack2003 modhack2003 commented Oct 15, 2026 •

Copy link
Copy Markdown
Owner

Quotes now lower the continuously looping theme to 20% of its configured level and restore it when playback ends or is canceled. With the default theme level, this is 75% → 15% → 75%, using a 150 ms reduction and 800 ms restoration. Theme mute takes priority throughout; the music source never restarts.

Theme startup no longer waits for the settings API. The document preloads the theme, and the mixer starts in parallel with fetching shared settings, using defaults until the saved settings arrive. Browser autoplay restrictions can still require a first tap or keypress.

The audio admin number fields now preserve editable string drafts instead of coercing an empty field to zero on each keystroke. Both fields can be cleared and retyped, including a zero or fractional fade duration. Save validates required values and ranges before sending numeric API values. The other admin numeric handlers already used string drafts; regression tests now cover collection fields (bounty, points, year) and clearing a repository's zero pin position.

Validation:

  • 35 Jest suites / 367 tests pass.
  • TypeScript, targeted ESLint, production build, and diff checks pass. The build used the existing empty-data fallback without production database credentials.
  • Chromium fixture used the actual bundled public/admin components and real MP3s. With the settings response delayed 10 seconds, theme playback began at 409 ms in the fixture. Verified quote ducking/restoration, no theme restart, mute priority after quote completion, active dialogue/effects while theme-muted, keyboard deletion of zero, blank-field validation, and retyped numeric saves. The fixture settings API was mocked; this is not a production startup timing guarantee or a live database-write test.

Follow-up to merged #21.
Commit: a569c24.

Vercel preview for this commit: READY — https://bikram-n0w6lejpg-modhack2003s-projects.vercel.app .

@vercel

vercel Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
bikram Ready Ready Preview Oct 16, 2026 5:24am UTC

@modhack2003
modhack2003 merged commit 0d00fe7 into main Oct 16, 2026
3 checks passed

This branch was successfully deployed

1 active deployment
Preview – bikram — f5f03612 Deployed Oct 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant