Repository navigation
fix(bson-types): use correct bson types COMPASS-10968 - #930
Merged
Merged
Conversation
mabaasit
requested review from
paula-stacho
and
a balanced review from Copilot
and removed request for
Copilot
October 20, 2026 11:16
addaleax
approved these changes
Oct 20, 2026
mabaasit
enabled auto-merge (squash)
October 23, 2026 16:52
|
coverage: 80.197% (+0.2%) from 79.988% — COMPASS-10968 into main |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes align with existing parser support, and no blocking issues were identified; tests were not executed.
No open issues 🎉
What changed in this PR
Updates BSON stringification and autocomplete metadata to use Long and Decimal128 instead of NumberLong and NumberDecimal, aligning with existing parser support.
Changes:
- Uses the updated constructor names in serialized BSON output.
- Updates corresponding test expectations and autocomplete entries.
- Corrects the 64-bit integer description.
| File | Description |
|---|---|
packages/shell-bson-parser/src/stringify.ts |
Emits Long and Decimal128 constructors. |
packages/shell-bson-parser/src/stringify.spec.ts |
Updates test names and expected serialized output. |
packages/mongodb-constants/src/bson-types.ts |
Updates autocomplete names and snippets; fixes a description typo. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Open Questions
Checklist