Repository navigation
RUBY-3982 Enable Lint/UnreachableCode cop - #3114
Merged
Merged
Conversation
Remove the cop's exclusion from .rubocop_todo.yml and fix the two offenses it reported. Sections::PayloadOne.deserialize is a deliberate NotImplementedError stub; delete the abandoned implementation below the raise and widen the signature to match its call site. In the unified test runner, drop a stray raise that made the intended Error::ErrorMismatch raise unreachable in the isTimeoutError branch.
jamis
requested review from
JamesKovacs and
comandeo-mongo
and removed request for
JamesKovacs
October 14, 2026 19:30
comandeo-mongo
previously approved these changes
Oct 19, 2026
comandeo-mongo
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up Lint/UnreachableCode by removing the cop's exclusion from .rubocop_todo.yml and fixing the two offenses it reported.
In Sections::PayloadOne.deserialize the method is an intentional NotImplementedError stub, so I deleted the abandoned implementation below the raise (its size arithmetic was wrong anyway) and widened the signature to match its two-argument call site.
In the unified test runner's isTimeoutError branch, a stray raise made the intended Error::ErrorMismatch unreachable; I removed it so the mismatch is reported as intended.