Repository navigation
RUBY-3952 Add no more to spans that are not recording - #3124
Open
comandeo-mongo wants to merge 1 commit into
Open
comandeo-mongo wants to merge 1 commit into
comandeo-mongo wants to merge 1 commit into
Conversation
Spans the sampler drops are still made current, so that nested spans stay nested and their context is propagated, but the tracers also built every attribute and recorded the outcome on them, all of which the SDK discards. Pass only the cheap attributes the OpenTelemetry spec recommends at creation, set the rest once the span is known to record, and record the outcome only on recording spans.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the sampler drops a span, the driver still built every attribute and recorded the outcome on it, and the SDK threw all of it away. Spans now start with the small set of attributes the OpenTelemetry spec recommends, get the rest only when they are recording, and record status, error attributes and exceptions only when recording. A dropped span is still made current, so nesting and context propagation are unchanged. Recorded spans look the same as before. Follows #3123.
Jira: https://jira.mongodb.org/browse/RUBY-3952