Skip to content

Exercise shell commands and aggregate supported-driver coverage - #27

Merged
dblock merged 1 commit into
mongoid:masterfrom
dblock:dblock/coverage
Oct 18, 2026
Merged

dblock merged 1 commit into
mongoid:masterfrom
dblock:dblock/coverage

Conversation

@dblock

@dblock dblock commented Oct 17, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Add meaningful rendering, argument registration, disconnected-primary, localized error, and fresh-process entrypoint tests.
  • Combine real supported Ruby/Mongoid matrix coverage on Coveralls rather than simulate legacy driver implementations.
  • Retain every tracked library file and preserve production behavior; allow fixture sockets to target a local test MongoDB port.

Verified results

  • Fresh upstream baseline 4271dd997da9b31edab35e70d939e581904c852e: 88.073%, 384/436 relevant lines, 52 missed.
  • Accepted aggregated Coveralls build 82425109: 100%, 434/434 relevant lines, 0 missed, across all nine real supported matrix entries.
  • Final CI run: all nine Ruby/Mongoid/MongoDB combinations pass; coverage finalization, RuboCop and Danger pass.
  • Local Ruby 3.3.5 / Mongoid 9: MONGODB_PORT=27040 COVERAGE=true bundle exec rake passes lint and 149 examples; 89.401% (388/434, 46 missed), with remaining legacy-driver paths covered by actual Mongoid 3/4 CI jobs.
  • Fresh-process entrypoints cover the version file before Bundler preloads it; executing that previously unloaded file correctly classifies two formerly tracked lines as non-executable (436 to 434 relevant lines). No filters, exclusions or tracked-file narrowing were added.
  • No database writes or purges. Tests only render commands, never execute MongoDB tools, and fixture socket transport was redirected to localhost:27040. No application database was accessed or modified; an isolated mongoid_shell_coverage database was therefore unnecessary.

Posted by GitHub Copilot on behalf of @dblock.

Collect real legacy and modern driver coverage from every supported CI job without changing runtime behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Danger Report

No issues found.

View run

@dblock
dblock merged commit 6d79a19 into mongoid:master Oct 18, 2026
13 checks passed
@dblock
dblock deleted the dblock/coverage branch October 18, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant