Repository navigation
Replace pymem with PyMemoryEditor in the auto extractor - #723
Open
JeanExtreme002 wants to merge 1 commit into
Open
JeanExtreme002 wants to merge 1 commit into
JeanExtreme002 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the auto extractor from pymem to PyMemoryEditor.
The comment above the process lookup says multiple NMS instances "will probably have issues". pymem matches the name as a substring and takes the first hit, so with a leftover NMS.exe around the script can read the wrong process and still write out templates. Now the name has to match exactly and it raises an error listing the PIDs if there is more than one. It also stops opening the game with PROCESS_ALL_ACCESS and the debug privilege, which a script that only reads memory doesn't need.
The read calls keep the same signatures apart from
read_stringtaking the length positionally, and the base address now comes from theNMS.exeentry inget_modules().I don't have NMS on a Windows machine at hand, so this was not run against the game. I only checked that the read calls return the same values on a similar memory layout, so it's worth one run against the current build before merging.