Skip to content

quest: plan three generic rules for the shared context - #529

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/context-rules
Nov 7, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/context-rules

Conversation

@kixelated

@kixelated kixelated commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Plans a quest to add three generic engineering rules to assets/CONTEXT.md, which quest context prints for every repository. moq-dev/rust2#553 dropped them from rust2's own instructions when it switched to quest context, because the shared context had no equivalent.

Changes

  • New [S] quest quest/m0/context-rules.md, last in m0's Required: match existing conventions, patterns, and naming; never pass a flaky test by loosening its assertion; short names under a module namespace.

Decisions

Settled with the maintainer on 2026-11-07, in a moq-dev/rust2 /quest-complete session:

  • Rules: ✅ conventions, ✅ flaky tests, ✅ short names (rejected: "keep the PR to one problem, no drive-by changes", which clashes with fixing bugs in touched code and stale docs inline; rejected: "offer to update an unclear skill").
  • Milestone: ✅ m0 (rejected: m1, m2).

Public API: none.

Validation

quest check (80 documents ok) and just check pass locally.

Models

Size: S
Implementer: Claude Code, claude-opus-5-5, high effort

(Written by Claude Opus 5.5 with high effort)

🤖 Generated with Claude Code

Review

Rewritten by quest review after each round.

  • Reviewer: Codex, gpt-6.1-sol, medium effort
  • Session: 01a1b382-a758-7901-b702-d460f6cd858a, round 1
  • Head: b224490
  • Base: origin/main at a3789c7
  • Score: 10/10, The diff adds a scoped planning document and its milestone link without changing runtime behavior, and quest validation passes for all 80 documents.
  • Findings: none

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@pullfrog

pullfrog Bot commented Nov 7, 2026

Copy link
Copy Markdown

Pullfrog  | Review this ➔

@kixelated
kixelated marked this pull request as ready for review November 7, 2026 00:58
@coderabbitai

coderabbitai Bot commented Nov 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 42 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 559ff092-7aef-433a-b15a-0ab7c7164517
Commits

Reviewing files that changed from the base of the PR and between a3789c7 and b224490.

Files selected for processing: 2

  • quest/m0/README.md
  • quest/m0/context-rules.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: b224490

No actionable findings. Reviewed both changed planning files and the existing shared context. The new quest matches the three stated rules and is linked from m0; it does not claim to implement the rules in this PR.

Direction: no change requested for this planning-only diff.

Verification limits: GitHub source inspection only; I did not run quest validation, builds, tests, or independently verify the PR author's local-check results. No executable behavior changed.

(Written by OpenAI)

@kixelated
kixelated added this pull request to the merge queue Nov 7, 2026
Merged via the queue into main with commit 4b07dd3 Nov 7, 2026
11 checks passed
@kixelated
kixelated deleted the quest-plan/context-rules branch November 7, 2026 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant