Skip to content

quest: finish model routing - #569

Merged
moq-bot[bot] merged 3 commits into
mainfrom
quest/m0/model-routing/README
Nov 8, 2026
Merged

moq-bot[bot] merged 3 commits into
mainfrom
quest/m0/model-routing/README

Conversation

@kixelated

@kixelated kixelated commented Nov 8, 2026 •

Copy link
Copy Markdown
Collaborator

Finishes quest/m0/model-routing/README.md. Its children (models, pins, kix-sessions) have landed, and live routed PRs already show what the epic still owed, so this PR deletes it and its links.

Evidence

Routed PRs from Claude Code, merged 2026-11-07, each with a Sol review recorded:

Changes

  • Deletes the epic README. With no children left, the epic goes away.
  • Removes the links to it from quest/m0/model-check.md's Goal and Required, from quest/m0/token-waste/usage.md's Required, and from quest/m1/model-check.md's Plan, which now points at src/cli/models.ts. Both m0 quests become unblocked. The m0 README listed nothing from the epic, so nothing needed to move.

Choices made without asking

Notes

Models

Size: S
Implementer: Claude Code, claude-opus-5-5, unknown effort

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Review

mechanical fix by codex, gpt-6.1-sol, medium effort: Merged base and re·solved the completed routing quest modify/delete conflict by retaining its deletion while preserving base code and guidance; ran just install, just check, and WRANGLER_SEND_METRICS=false just test. (head d404073)

Rewritten by quest review after each round.

  • Reviewer: Codex, gpt-6.1-sol, medium effort
  • Session: 01a1b8c9-cce6-7ca1-a146-507b83f84b55, round 1
  • Head: f4e8af2
  • Base: origin/main at b7fb7f8
  • Score: 10/10, The change removes the completed routing quest and updates its remaining references without changing executable code or leaving dangling links.
  • Findings: none

@pullfrog

pullfrog Bot commented Nov 8, 2026

Copy link
Copy Markdown

Pullfrog  | Review this ➔

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Route quests to models by size quest: finish model routing Nov 8, 2026
@kixelated
kixelated marked this pull request as ready for review November 8, 2026 01:33
@coderabbitai

coderabbitai Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7d4af814-3f97-444e-94c5-a181624e3d00
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated
kixelated added this pull request to the merge queue Nov 8, 2026

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head: f4e8af2
Compared base: b7fb7f8

[P2] Preserve the live-routing acceptance check until it has evidence
Location: quest/m0/model-routing/README.md:15-17 (deleted).

The remaining goal requires a live spawn exercising XS on Haiku and S on Opus. The cited XS examples, moq-dev/quest#544 and moq-dev/quest#552, merged before the ranked-list implementation in moq-dev/quest#558, and this PR explicitly says their coordinator selected Haiku by hand. Those records establish that Haiku can implement reviewed quests, but do not establish that the new models selection consumed by /quest-spawn actually dispatches an XS quest to it.

Deleting the epic drops that outstanding acceptance check. The retained m0/m1 model-check plans only audit subsequent PR records and retune tables; neither requires performing the missing live spawn, so this can remain untested even after the audit completes. Keep the remaining check until a run of the implemented routing is recorded, or explicitly carry that acceptance work into the surviving model-check quest rather than relying on the PR-body caveat.

Direction: address the completion-evidence gap before treating the epic as finished. Submitted as COMMENT, not approval.

Scope: static GitHub review of all four changed files, the surviving audit plans, routing configuration and spawn instructions, and the cited PR records. No repository code, commands, builds, or tests were run. This finding concerns missing completion evidence, not a demonstrated runtime routing failure.

(Written by review (OpenAI))

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 8, 2026
@moq-bot

moq-bot Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

quest land watch: the merge queue removed this pull request at f4e8af2 because it conflicts with main (merge_conflict).

The land fixer works on it in the background, and the watcher re-enqueues it at the back of the queue once it is fixed or judged flaky, or hands it back here with what it needs.

(written by quest land watch)

@moq-bot
moq-bot Bot enabled auto-merge November 8, 2026 01:49
@moq-bot

moq-bot Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

codex, gpt-6.1-sol, medium effort land fixer note:

Resolved the conflict by retaining the deletion of the completed routing quest. The base revision to latest-writer review policy remains intact in its code and surviving guidance. No runtime behavior changed. Validation passed: just install, just check, and WRANGLER_SEND_METRICS=false just test (1,185 CLI tests and 545 Worker tests, plus installer, build, lifecycle, and seeded checks).

(written by codex, gpt-6.1-sol, medium effort)

@moq-bot

moq-bot Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

quest land watch: armed auto-merge on this pull request at d404073, so it joins the back of the merge queue once its required checks pass, with the land fixer's fix (codex, gpt-6.1-sol, medium effort): Merged base and re·solved the completed routing quest modify/delete conflict by retaining its deletion while preserving base code and guidance; ran just install, just check, and WRANGLER_SEND_METRICS=false just test..

(written by quest land watch)

@moq-bot
moq-bot Bot added this pull request to the merge queue Nov 8, 2026
Merged via the queue into main with commit 73270c9 Nov 8, 2026
9 checks passed
@moq-bot
moq-bot Bot deleted the quest/m0/model-routing/README branch November 8, 2026 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant