Skip to content

quest: plan mem::needs_drop as each instance's constant - #483

Merged
moq-bot[bot] merged 2 commits into
mainfrom
quest-plan/ts-needs-drop
Nov 3, 2026
Merged

moq-bot[bot] merged 2 commits into
mainfrom
quest-plan/ts-needs-drop

Conversation

@kixelated

@kixelated kixelated commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

std::mem::needs_drop::<T>() is refused as an unsupported call, while size_of::<T>() translates as its value. Found while reproducing moq-dev/rust2#480.

Approach

Plan it as an m3 quest, quest/m3/ts-needs-drop.md: translate it as rustc's constant for each instance, proven by a differential test against native Rust.

Impact

  • None: quest tree only.

Alternatives

Follow-ups

  • None.

Review

mechanical fix by quest land watch: merged main at c8e039785f3a40be3bd8b0c93c7d5e9f9eb63379 with the quest merge driver (head 5e7d346)

Skipped: a quest-only change, too trivial to review. just check passed.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9fb3bf7f-69db-4bc6-83f1-bff2235b5f54
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@kixelated
kixelated added this pull request to the merge queue Nov 3, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 3, 2026
@moq-bot

moq-bot Bot commented Nov 3, 2026

Copy link
Copy Markdown

quest land watch: the merge queue removed this pull request at 6a09a29 because it conflicts with main (merge_conflict).

The land fixer works on it in the background, and the watcher re-enqueues it at the back of the queue once it is fixed or judged flaky, or hands it back here with what it needs.

(written by quest land watch)

@moq-bot
moq-bot Bot enabled auto-merge November 3, 2026 04:55
@moq-bot

moq-bot Bot commented Nov 3, 2026

Copy link
Copy Markdown

quest land watch: armed auto-merge on this pull request at 5e7d346, so it joins the back of the merge queue once its required checks pass, with main at c8e0397 merged in by the quest merge driver.

(written by quest land watch)

@moq-bot
moq-bot Bot added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit 6f2b8fb Nov 3, 2026
5 checks passed
@moq-bot
moq-bot Bot deleted the quest-plan/ts-needs-drop branch November 3, 2026 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant