Skip to content

chore(quest): plan function pointer patterns and char methods - #503

Merged
kixelated merged 2 commits into
mainfrom
quest-plan/str-pattern-gaps
Nov 3, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest-plan/str-pattern-gaps

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

Testing #495 turned up two gaps that are out of its scope: a function pointer or boxed closure used as a str pattern, and char methods that have no mapping.

Approach

Two new m3 quests. I probed each case on main at 7c41f2b1 with a scratch crate first, so both quests record observed results:

  • quest/m3/ts-fn-patterns.md: fn(char) -> bool (by value and &), Box<dyn FnMut(char) -> bool> (by value and &mut), and Box<{closure}> are all refused as "unsupported call" by contains and split.
  • quest/m3/ts-char-methods.md: no existing quest covered char methods. It lists each unmapped method the probe refused, called and as a value (classes, case, escapes, UTF-16 and UTF-8 encoding, from_digit, TryFrom<u32>). It also lists the mapped methods that already translate as values, so the gap is the mapping, not the function value.

Impact

  • None: quests only.

Alternatives

  • One combined quest: rejected, as the two are independently landable.

Follow-ups

  • None.

Review

  • Codex, gpt-6.1-sol, medium, round 1, head a920aa79: no findings.
  • Head 8d1ec238 adds only a conflict-free merge of origin/main; just check passed on it.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 50 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b51c97de-5aa0-4aac-a4f6-adb9c103bcd4
Commits

Reviewing files that changed from the base of the PR and between 2950376 and 8d1ec23.

Files selected for processing: 3
  • quest/m3/README.md
  • quest/m3/ts-char-methods.md
  • quest/m3/ts-fn-patterns.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@kixelated
kixelated added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit a7901d2 Nov 3, 2026
3 checks passed
@kixelated
kixelated deleted the quest-plan/str-pattern-gaps branch November 3, 2026 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant