Repository navigation
quest: adopt m3's unsafe policy; delete Vec::from_raw_parts - #649
Conversation
Quest-Claim: 54f667d07727f9fd
The spike's findings: translation reads each import's JS shape from the program wasm-bindgen's macro encodes in a link_section static, since source reading misses the macro_rules!-made imports on the encoder's path. The imports quest is rewritten to it and split: closures, js-sys's futures, and the VideoEncoder test in headless Chromium move to a closures quest. The epic records tokio::sync as a further gap for web-codecs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… stay refused Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit b7f23c1 against base 48a0fae, separating the previously reviewed #648 stack at a1d4c2b from this PR's three-document delta.
No actionable findings in the new planning changes. The m3 policy, narrowed unsafe epic goal, historical notes, and removal of the Vec::from_raw_parts quest/list entry are consistent. The stated direction is explicit: prioritize safe APIs and existing pointer representations, refuse unsupported constructs, and defer broader memory models or WASM wrappers until a consumer requires them. No executable translator or runtime behavior changes in this PR.
Verification limits: GitHub-only static documentation review. I did not execute quest validation or independently assess the abandoned implementation's storage-metadata requirements. Existing runtime limitations are not resolved by this policy change. This is a COMMENT, not an approval.
(Written by review (OpenAI))
# Conflicts: # quest/m3/ts-wasm-bindgen/README.md
…e-policy # Conflicts: # quest/m3/ts-wasm-bindgen/README.md
…uest-delete/ts-unsafe-policy
|
quest land watch: the merge queue removed this pull request at 837f7af because it conflicts with The land fixer works on it in the background, and the watcher re-enqueues it at the back of the queue once it is fixed or judged flaky, or hands it back here with what it needs. (written by quest land watch) |
|
quest land watch: armed auto-merge on this pull request at ddd387f, so it joins the back of the merge queue once its required checks pass, with the land fixer's fix ( (written by quest land watch) |
|
quest land watch: the merge queue removed this pull request at ddd387f because it conflicts with The land fixer works on it in the background, and the watcher re-enqueues it at the back of the queue once it is fixed or judged flaky, or hands it back here with what it needs. (written by quest land watch) |

Summary
quest/m3/README.md, replacing the narrower 2026-11-07 note from moq-dev/rust2#648.Vec::from_raw_partsquest. moq-dev/rust2#635 is closed: it needed a WeakMap of adopted storage, metadata kept apart from the pointer.This PR is built on #648's head (a1d4c2b, queued), which is built on moq-dev/rust2#638 (queued). Until both land, this diff also shows their changes.
Decisions
Decided with the maintainer on 2026-11-07, to stop one-off fixes for increasingly rare
unsafe:unsafeinside std and common crates is wrapped at their safe API (std,hashbrown,bytes, tokio's channels), not translated.unsafetranslates only where it fits the existing pointer forms: a place, an array element, or a byte in a buffer. A construct that needs a new pointer form or pointer metadata is refused with its span, unless a consumer needs it and no library wrapper covers it.unsafe-heavy crate that a consumer needs is compiled to WASM behind its public API, not fixed construct by construct. This isn't planned until a consumer needs it.Vec::from_raw_partsand stop feat(ts): translate Vec::from_raw_parts of memory from alloc or a Vec's #635.Rejected:
The other ts-unsafe PRs in flight fit rule 3, so they continue:
WrittenIn, which is anrs.Place.🤖 Generated with Claude Code
(Written by Claude Opus 5.5 with high effort)
Review
mechanical fix by quest land watch:
merged main at 7301a08dbec95030c7df6e263ec3b138812aaffc with the quest merge driver(head f532b3f)mechanical fix by codex, gpt-6.1-sol, medium effort:
Merged base and re·solved quest/m3/README.md conflict retaining both policy passages; just check base and just test base passed.(head ddd387f)Rewritten by
quest reviewafter each round.01a1b698-b7c6-7900-8390-a08de1492b12, round 1The specified diff only updates quest documentation and planning scope, with no actionable defects or remaining references to deleted quest files.