Replace repoze.lru.lru_cache with functools.lru_cache - #75
Open
henri-hulski wants to merge 1 commit into
Open
henri-hulski wants to merge 1 commit into
henri-hulski wants to merge 1 commit into
Conversation
henri-hulski
changed the title
henri-hulski
force-pushed
the
lru_cache
branch
from
September 30, 2026 16:44
3145a51 to
fc6ebfb
Compare
|
coverage: 100.0%. remained the same — lru_cache into master |
henri-hulski
changed the title
Daverball
approved these changes
Sep 30, 2026
Daverball
left a comment
Daverball
left a comment
Contributor
There was a problem hiding this comment.
Looks good, I only have a small suggestion.
Comment on lines
+91
to
+94
| def _all(key: Sequence[Any]) -> list[_ValueT]: | ||
| return list(key_lookup.all(key)) | ||
|
|
||
| self.all = lru_cache(all_cache_size)(_all) |
Contributor
There was a problem hiding this comment.
Suggested change
| def _all(key: Sequence[Any]) -> list[_ValueT]: | |
| return list(key_lookup.all(key)) | |
| self.all = lru_cache(all_cache_size)(_all) | |
| @lru_cache(all_cache_size) | |
| def _all(key: Sequence[Any]) -> list[_ValueT]: | |
| return list(key_lookup.all(key)) | |
| self.all = _all |
Might as well use the decorator syntax here
henri-hulski
force-pushed
the
lru_cache
branch
2 times, most recently
from
October 1, 2026 19:35
1e05e13 to
4060ff8
Compare
henri-hulski
force-pushed
the
lru_cache
branch
from
October 1, 2026 19:42
4060ff8 to
266b03a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixed the registry tests and added tests for the cache.