Repository navigation
Conversation
tiftran
force-pushed
the
merino-seq-sid
branch
from
October 30, 2026 21:48
25f40a0 to
22004d7
Compare
tiftran
force-pushed
the
merino-seq-sid
branch
from
October 30, 2026 23:20
22004d7 to
506e398
Compare
tiftran
commented
Oct 31, 2026
| viaduct = { path = "../viaduct", features = ["ohttp"] } | ||
| error-support = { path = "../support/error" } | ||
| thiserror = "2" | ||
| parking_lot = "0.12" |
Contributor
Author
There was a problem hiding this comment.
seemed like what other components were using?
ncloudioj
approved these changes
Nov 2, 2026
|
|
||
| /// Returns the session ID and sequence number to send with the next request, | ||
| /// starting a new session if there isn't one, and advances the sequence number. | ||
| fn next_session_params(&self) -> (String, u32) { |
Member
There was a problem hiding this comment.
Nit: the returned tuple is not actually the next session state but the current one. Rename it to advance_session() might sound more reasonable. We can note that this method will return the pre-advance session state.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
[ci full]to the PR title.