Repository navigation
Deduplicate ESDTTransfer events only across shards - #1650
Open
stefangutica wants to merge 2 commits into
Open
stefangutica wants to merge 2 commits into
stefangutica wants to merge 2 commits into
Conversation
|
k6 load testing comparison.
Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning
removeDuplicatedESDTTransferEventsdropped everyESDTTransferevent with identical content, including legitimate repeats emitted on the same shard. For example,9a4e275b6a272431e324da6011fbe87715214f82407b269a25e26032bdd25bcdhas 4 SCRs and 4ESDTTransferevents, two identical pairs on shard 1. The API returned only 2 events and 2 token operations.txHash.Proposed Changes
shardIDto the log events. It is now exposed aslogs.events[].shardID.ESDTTransferevent is dropped only when an identical one was already seen on a different shard. Repeats on the same shard are kept.How to test
GET /transactions/9a4e275b6a272431e324da6011fbe87715214f82407b269a25e26032bdd25bcdreturns 4ESDTTransferevents inlogsand 4 WEGLD transfers inoperations.GET /transactions/38b1e7163db09950d24fc015b74a129017694f51d20a5053fbc14d2a2dcee97f(cross-shard) still returns the initial ZPAY transfer once, from shard 0.