Repository navigation
Fit the rack requirement within RubyGems' 255-character limit - #74
Merged
Merged
Conversation
RubyGems refused the 5.8.4 push because the rack requirement, which excluded each vulnerable 3.x release by name, was 542 characters. Require rack 2.2.23 or later and warn once at load time when the installed Rack is a vulnerable 3.x release (3.0.x, 3.1.0 to 3.1.20, or 3.2.0 to 3.2.5), naming the fixed release. Rack 2.2 applications remain supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rack requirement fits RubyGems' limit
A fix for the 5.8.4 publish. RubyGems refused the push with "Dependency requirements is too long (maximum is 255 characters)": the
rackrequirement, which excluded each vulnerable 3.x release by name, was 542 characters. No version bump; 5.8.4 is re-tagged on the merge commit.Changes
rack2.2.23 or later (below 4), which fits the limit and keeps Rack 2.2 applications supported.Testing
gem buildproducesrack >= 2.2.23, < 4.