Repository navigation
feat(tools): build deck generation into doc_gen - #288
Merged
Merged
Conversation
Add a chat tool that schedules the marp_slides ExApp's deck generation task through the shared run_task helper. The tool takes a deck brief (the provider's own AI authors the full Marp Markdown from it), not slide contents, and returns the assistant download link for the generated PPTX. Availability is gated on the task type being registered server-side. The link correctly extracts absolute_url from the app_api OCS response dict rather than f-stringing the whole response. Depends on: #286 Assisted-by: opencode (zai/glm-5.3) Signed-off-by: WSHAPER <42714629+WSHAPER@users.noreply.github.com>
WSHAPER
force-pushed
the
feat/slide-deck-tool
branch
from
October 25, 2026 09:58
03dedd1 to
a592c72
Compare
Member
|
Looks good. I wonder if we should build this into the doc_gen tool instead of potentially exposing two tools that do the same thing. What do you think? |
Contributor
Author
Yeah, sounds good. |
The review of PR #288 asked for one tool instead of two overlapping ones, so the standalone slide_deck tool is gone and decks are routed through generate_document's "slides" format. The slides case now prefers the marp_slides ExApp: when its slide_deck_generation task type is registered server-side, dispatch it with the "prompt" input key and no output_format key (the task type's default applies), otherwise fall back to the existing richdocuments:slide_deck_generation dispatch with the "text" input key. Both task types answer with the slide_deck output key, so the download link construction stays shared across the slides branches. is_available also reports the tool on instances that only have the ExApp installed, not just where richdocuments is enabled. Assisted-by: opencode (zai/glm-5.3) Signed-off-by: WSHAPER <42714629+WSHAPER@users.noreply.github.com>
Contributor
Author
|
Built into doc_gen in 1e3941d as suggested: the slides format prefers the marp_slides ExApp task type when registered and falls back to richdocuments' deck task otherwise, the standalone tool is gone. doc_gen is now also available on instances that only have the ExApp. |
WSHAPER
changed the title
marcelklehr
reviewed
Oct 27, 2026
Derive the offered formats from the task processing task types registry instead of the richdocuments capability: the docstring only lists formats whose backing task type is registered, unservable format requests fail soft with the available formats, and is_available is true iff at least one format is servable. Assisted-by: opencode (zai/glm-5.3) Signed-off-by: WSHAPER <42714629+WSHAPER@users.noreply.github.com>
marcelklehr
reviewed
Nov 4, 2026
marcelklehr
approved these changes
Nov 4, 2026
Co-authored-by: Marcel Klehr <mklehr@gmx.net> Signed-off-by: Ilia Karpov <42714629+WSHAPER@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per review feedback, deck generation lives in the doc_gen tool instead of a standalone tool, so there is exactly one tool for office document generation.
Summary
slidesformat now prefers the slides ExApp: whenmarp_slides:slide_deck_generationis registered server-side, the brief is passed as thepromptinput and the task type default output format applies (no hardcoding).richdocuments:slide_deck_generationwith thetextinput when the ExApp is not installed. Both task types answer with theslide_deckoutput key, so the download link construction stays shared.is_availableis true when richdocuments is in the capabilities OR the ExApp task type is registered, so instances with only the ExApp still get the tool for decks.Tests
test_doc_gen_links.pyextended: marp preference, richdocuments fallback, both download link shapes and the availability matrix. Full suite: 37 passing.Assisted by opencode with zai/glm-5.3, reviewed by WSHAPER