feat: Add 'reversibility' and 'item count' to action classification by marcelklehr · Pull Request #298 · nextcloud/context_agent

marcelklehr · 2026-10-28T11:33:19Z

Reversibility and item coutn are now two more dimensions of the tool action classification, each with its own admin threshold.

How it decides

A batch of tool calls is confirmed with the user as soon as any of teh five gates is reached:
- Impulse radius (unchanged)
- Deletion: a deletion or overwrite reaching the deletion threshold
- Irreversible: An action that can't be undone, reaching the new irreversible threshold
- Item count: more items than the new count threshold, added up over the whole batch
- Always confirm: unchanged
Reversibility has three levels: REVERSIBLE, RECOVERABLE (only from a trash bin or version history), and IRREVERSIBLE (gone for good, or already sent)
Item count includes the contents of folders subpages and so on. Read only tools count 0.
No answer means worst case: MCP tools, tools without the new markers and hooks that fail are treated as irreversible with an unknown item count, so they are always confirmed.

New admin settings (defaults in brackets):

Confirm actions that can't be undone from this radius on [individual people]
What counts as "can't be undone"? Only actions that are gone for good or also ones that need a trashbin restore [gone for good only]
Don't ask about deletion that can be undone directly [off]
Confirm when more than N items are changed [10]

One bhevior change: The deletion gate now uses the reach of the deletion itself. Before, it used the wides radius in the whole batch. For example: Deleting a priovate note while also sharing sopmething with a group is now judged on the note's reach. I think that makes more sense.

🤖 AI (if applicable)

The content of this PR was partly or fully generated using AI (N/A)

marcelklehr · 2026-10-28T11:45:42Z

Decisions I made, that are worth a look:

Edits that keep no history count as irreversible
Folder moves and copies count every file inside
Talk messages to large audiences are still count=1
DEleting from external storage, some group folders or a received federated share is permanent, but classified RECOVERABLE.

lukasdotcom

For file share editing/creating/deleting the item count should also use the count of files in the folder if it is a folder like in copy_file IMO.

julien-nc

Code looks good. A few comments/questions.

kyteinsky · 2026-11-04T12:25:43Z

+	async def form_size(form_id):
+		"""Deleting a form takes every submission it collected along with it."""
+		payload = await nc.ocs('GET', f'/ocs/v2.php/apps/forms/api/v3/forms/{form_id}/submissions')
+		submissions = payload.get('submissions') if isinstance(payload, dict) else None
+		if submissions is None:
+			raise ValueError(f'Could not read the submissions of form {form_id!r}')
+		return 1 + len(submissions)


nit: seems like we can use a hack here to make this less compute intensive
passing limit = 1 here still gives us the count of all the submissions without actually hydrating the submission objects. The key filteredSubmissionsCount has the count.
https://github.com/nextcloud/forms/blob/fa6bbd7dea20a2c7ed7766e8c86282de848c3388/lib/Controller/ApiController.php#L1277

kyteinsky · 2026-11-04T12:53:11Z

just an idea, not sure if it's worth pursuing, for changes like table title updates, we could make them reversible in the true sense by fetching the old title before making the change.
after the change, we return both the old and the new titles to the agent making it reversible and having in the agent's context.
it does not work for large fields though, and adds an extra GET request.

marcelklehr · 2026-11-04T13:36:47Z

after the change, we return both the old and the new titles to the agent making it reversible

That's not the sense of reversible that is meant here, I think. it's not about whether the agent can revert the action on its own, but whether it's possible to revert (the consequences of) the action in general.

I think the consequences of any simple title change are negligible, because it's usually quite easy to restore the title by hand, even if there is no explicit undo functionality.

kyteinsky · 2026-11-04T13:42:26Z

fair enough.

marcelklehr · 2026-11-05T10:26:04Z

Blockers:

~~deletion on External storage should be IRREVERSIBLE~~ It goes to trashbin as well, so RECOVERABLE is fine
Make changing title IRREVERSIBLE
Add a CI check that all tools have all markers

Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Epistemologically, the information is exposed at the time he share is created, even if the share can be deleted, the information was leaked already. Hence, irreversible. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>

API doesn't offer that Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>

…ERSIBLE Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>

…ved threshold getters Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>

marcelklehr requested review from WSHAPER, julien-nc, kyteinsky and lukasdotcom October 28, 2026 11:33

lukasdotcom reviewed Oct 28, 2026

View reviewed changes

marcelklehr requested a review from lukasdotcom October 29, 2026 14:00

julien-nc reviewed Nov 3, 2026

View reviewed changes

Comment thread ex_app/lib/all_tools/talk.py Resolved

Comment thread ex_app/lib/all_tools/cookbook.py Resolved

Comment thread ex_app/lib/all_tools/deck.py Resolved

Comment thread ex_app/lib/all_tools/files.py Resolved

marcelklehr requested a review from julien-nc November 4, 2026 12:04

julien-nc approved these changes Nov 4, 2026

View reviewed changes

kyteinsky reviewed Nov 4, 2026

View reviewed changes

marcelklehr added 15 commits November 5, 2026 14:35

feat: Add 'reversibility' and 'item count' to action classification

9390dcb

Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>

fix: Events with attendees count as irreversible

6a0e822

Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>

fix: Pass unquoted path to count_file_tree

c751a4e

Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>

fix(settings): Correct settings text to match implementation

9360d49

Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>

fix(shares): Team and talk convo shares should be REVERSIBLE

1ffa344

Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>

fix(circles): update_circle should be IRREVERSIBLE

dac2775

Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>

perf: Fetch all settings at once

fb87202

Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>

fix(classification): Make share tools count files in shared folders

1e5a9ea

Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>

fix(cookbook): Make reversibility of delete_recipe dependent on trashbin

9ff33e7

Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>

fix(collectives): trash_subtree_size cannot be known in most cases

2af9f29

API doesn't offer that Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>

fix(shares): Make update_share_permissions IRREVERSIBLE

86b907f

API doesn't offer that Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>

fix: Changes that overwrite a title or similar metadata are now IRREV…

3d54f33

…ERSIBLE Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>

test: Check whether all tools have all necessary markers

3f4e9db

Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>

test(concurrent_users): Patch get_confirmation_policy instead of remo…

04fb1d2

…ved threshold getters Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>

marcelklehr force-pushed the feat/reversibility-and-item-count branch from 568d92d to 04fb1d2 Compare November 5, 2026 13:37

marcelklehr merged commit ef3162e into main Nov 5, 2026
8 checks passed

marcelklehr deleted the feat/reversibility-and-item-count branch November 5, 2026 14:14

Navigation Menu

Repository navigation

feat: Add 'reversibility' and 'item count' to action classification - #298

feat: Add 'reversibility' and 'item count' to action classification#298
marcelklehr merged 15 commits into
mainfrom
feat/reversibility-and-item-count

marcelklehr commented Oct 28, 2026 •

edited

Loading

Uh oh!

marcelklehr commented Oct 28, 2026 •

edited

Loading

Uh oh!

lukasdotcom left a comment

Uh oh!

julien-nc left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kyteinsky Nov 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kyteinsky commented Nov 4, 2026

Uh oh!

marcelklehr commented Nov 4, 2026

Uh oh!

kyteinsky commented Nov 4, 2026

Uh oh!

marcelklehr commented Nov 5, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

marcelklehr commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 AI (if applicable)

Uh oh!

marcelklehr commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lukasdotcom left a comment

Choose a reason for hiding this comment

Uh oh!

julien-nc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kyteinsky Nov 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kyteinsky commented Nov 4, 2026

Uh oh!

marcelklehr commented Nov 4, 2026

Uh oh!

kyteinsky commented Nov 4, 2026

Uh oh!

marcelklehr commented Nov 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

marcelklehr commented Oct 28, 2026 •

edited

Loading

marcelklehr commented Oct 28, 2026 •

edited

Loading

marcelklehr commented Nov 5, 2026 •

edited

Loading