Repository navigation
feat: Add swimlane grouping by labels and assignees - #7875
Pavlinchen wants to merge 2 commits into
Conversation
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Force pushed new (rebased) version to incorporate GanttView |
|
on it! |
grnd-alt
left a comment
There was a problem hiding this comment.
Hey, thanks for your pr and the much appreciated work you did here.
Did not review the code fully but wanted to leave some comments from testing:
- there's a lot of layout shift when cards are moved between stacks as the column width changes.
- the order of lanes randomly changes when moving in columns in one lane
- the "order by" setting is persisted between site refreshes but the settings radio button's don't reflect it after refresh
- more of an opinion: I don't know if it's really necessary to have the column names listed for every lane, and them having different widths per lane seems counter-intuitive as well (but that's more of a design question idk what's better here)
| public function __construct( | ||
| private readonly IConfig $config, | ||
| private readonly IGroupManager $groupManager, | ||
| private readonly PermissionService $permissionService, |
There was a problem hiding this comment.
that's a circular dependency and breaks the app
|
Hello again & thanks for the patience.
|
|
Hi @grnd-alt, following up here. The June revision (20dbf48) covers the points from your May review. Is this PR something this project wants? If the answer is yes: which base should I target? So I can rebase onto main as it stands and or stack on top of #8259 - lmk Thanks in advance & |
|
@Pavlinchen I must say, I personally do not see a need for swimlanes to be honest. But it seems to be somewhat wanted by the community as there's a 10year old issue with some likes about it. I am open to have it in, but I do see the risk of increased complexity and maintenance cost, especially since we have the gantt chart which is in a not so good state performance whise right now. So if you are motivated to have it in and think you'll get it in a very good state that's easily maintainable, I would say go on! In regards to the rebase, I am currently mainly working on a refactor to move to vue3: #8276 The pr you mentioned is incorporated into the vue3 rewrite I would advise you to wait until that is merged. |
|
Will pick this back up in ~4 weeks |
Groups cards into horizontal lanes by label or assignee, with a "No label" / "Unassigned" catchall lane. A card with several labels shows up in every matching lane and carries a badge. The flat board stays the default. Mode and lane order are shared board settings, stored as three columns on deck_boards. ConfigController routes them to BoardService, which validates them once the EDIT permission check has passed. Closes nextcloud#32 Signed-off-by: Pavlinchen <69079839+Pavlinchen@users.noreply.github.com>
20dbf48 to
8db86c2
Compare
|
Hi @grnd-alt, thanks for your patience. There have been quite a few changes, so here is what changed and why.
Mode and lane order also moved from app config entries to three |
- Lanes are as wide as their columns, so narrow windows no longer clip the last columns inside smooth-dnd's overflow: hidden wrapper. - Header and lane columns ignore their content width, so a long card or stack title no longer shifts lane columns against the header row. - Cloned card containers in the lane ghost no longer catch the drop point, so dragging a lane downwards finds its target again. - Cypress covers all three cases. Signed-off-by: Pavlinchen <69079839+Pavlinchen@users.noreply.github.com>
Summary
Adds an optional horizontal swimlane grouping to the board view.
Users can now group cards by labels or assignees via the existing "View Modes" menu. Each group renders as a collapsible horizontal row with its own set of stacks, showing only the cards that belong to that group.
Key behaviors:
PERMISSION_EDIT)Example Screenshot
How it works
SwimlanecomponentsSwimlanerenders aSwimlaneHeader(with label color/avatar, card count, collapse toggle) and the same horizontal stack layoutlaneprop - when present, it usescardsByStackAndLaneMapto filter cards for that laneKnown gaps
Checklist
🤖 AI (if applicable)