Repository navigation
Feat/federated sharing #8184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
luka-nextcloud
wants to merge
12
commits into
main
Choose a base branch
from
feat/federated-sharing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/federated sharing #8184
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b497f26
feat: add federated sharing
luka-nextcloud 98ed4dc
feat: add leaving board on remote & update users look and feel
luka-nextcloud 22e3190
fix: mentioning federated user in card comment
luka-nextcloud e35d67b
feat: localize federated user mention in card comment
luka-nextcloud 89d31b2
feat: share card attachment to federated user
luka-nextcloud a9d9a08
feat: implement remote attachment
luka-nextcloud bebaf82
feat: implement remote attachment creation
luka-nextcloud a101e17
feat: implement remote attachment creation
luka-nextcloud bcaab30
feat: enhance attachment readiness handling & fix unit tests
luka-nextcloud 53f1070
fix: resolve merge conflicts
luka-nextcloud eda2437
fix: resolve workflow issues
luka-nextcloud 2be9ceb
fix: assignment selector & remote attachment
luka-nextcloud File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
boardIdis optional butfind()is now always called with it, so requests withoutboardIdfail with a500. This is potentially a breaking API change and could affect existing clients. Could we keep theif ($boardId)check fromensureLocalBoard()here and increate()/delete()? Same inCardOcsController::update(), whereboardIdbecame required.Since this check is repeated in a lot of controllers now, maybe a small helper like
BoardService::findExternalBoard(?int $boardId): ?Board(returning the board only if it's federated) would make this simpler and avoid missing the null check again.