Skip to content

nmc/7006-incorrect-audio-file-icon-in-search-result - #534

Open
suet-kei-chan wants to merge 1 commit into
stable33from
nmc/7006-incorrect-audio-file-icon-in-search-result
Open

suet-kei-chan wants to merge 1 commit into
stable33from
nmc/7006-incorrect-audio-file-icon-in-search-result

Conversation

@suet-kei-chan

Copy link
Copy Markdown
Contributor

In the unified search modal, audio files (e.g. .mp3) were displayed with the folder icon on dev/pre/prod instead of their mimetype icon.

Core adds the result-item__icon--no-preview class to every result that has no thumbnail. The theme applied the blue folder icon with !important to both .icon-folder and --no-preview, which overrode the inline mimetype icon set by core for any file without a preview.

Locally this was hidden because OC\Preview\MP3 was enabled in enabledPreviewProviders, so MP3 files had a thumbnail. On environments without that provider, MP3s (and any other file type without preview support) fell back to --no-preview and showed the folder icon.

Restrict the folder background image to .icon-folder only, while keeping the shared 42px sizing and positioning for --no-preview items so files without previews render their correct mimetype icon.

In the unified search modal, audio files (e.g. .mp3) were displayed with
the folder icon on dev/pre/prod instead of their mimetype icon.

Core adds the `result-item__icon--no-preview` class to every result that
has no thumbnail. The theme applied the blue folder icon with
`!important` to both `.icon-folder` and `--no-preview`, which overrode
the inline mimetype icon set by core for any file without a preview.

Locally this was hidden because `OC\Preview\MP3` was enabled in
`enabledPreviewProviders`, so MP3 files had a thumbnail. On environments
without that provider, MP3s (and any other file type without preview
support) fell back to `--no-preview` and showed the folder icon.

Restrict the folder background image to `.icon-folder` only, while
keeping the shared 42px sizing and positioning for `--no-preview` items
so files without previews render their correct mimetype icon.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@suet-kei-chan suet-kei-chan self-assigned this Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant