Skip to content

nmc/6932-button-texts-in-file-conflict-dialog-not-aligned - #536

Open
suet-kei-chan wants to merge 1 commit into
stable33from
nmc/6932-button-texts-in-file-conflict-dialog-not-aligned
Open

suet-kei-chan wants to merge 1 commit into
stable33from
nmc/6932-button-texts-in-file-conflict-dialog-not-aligned

Conversation

@suet-kei-chan

Copy link
Copy Markdown
Contributor

The action buttons of the upload conflict dialog (Abbrechen, Diese Datei überspringen, Fortsetzen) reserved space for icons that were not rendered properly, which pushed the button labels off-center.

  • Remove setupConflictIcons() from nmcfiles.ts, which injected close/copy-paste/arrow-right SVG icons into the conflict picker buttons via a MutationObserver (the keep-both selector no longer matches any button in @nextcloud/upload)
  • Hide the .button-vue__icon wrapper of the dialog action buttons and center the button content in files.scss
  • Drop the obsolete rules that forced the button SVGs to display

The action buttons of the upload conflict dialog (Abbrechen,
Diese Datei überspringen, Fortsetzen) reserved space for icons that
were not rendered properly, which pushed the button labels off-center.

- Remove setupConflictIcons() from nmcfiles.ts, which injected
  close/copy-paste/arrow-right SVG icons into the conflict picker
  buttons via a MutationObserver (the keep-both selector no longer
  matches any button in @nextcloud/upload)
- Hide the .button-vue__icon wrapper of the dialog action buttons and
  center the button content in files.scss
- Drop the obsolete rules that forced the button SVGs to display

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@suet-kei-chan suet-kei-chan self-assigned this Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant