Repository navigation
nmc/6933-search-dog-image-background-not-fully-optimized-for-dark-mode - #537
Open
suet-kei-chan wants to merge 1 commit into
Open
suet-kei-chan wants to merge 1 commit into
suet-kei-chan wants to merge 1 commit into
Conversation
The unified search empty state replaces the magnify icon with the cautious-dog illustration. Unlike the other decorative images (e.g. the mouse in the files view), it had no dark variant, so in dark mode it was shown with its light grey backdrop blob and ground, which made the background look not fully transparent. - Add cautious-dog-dark.svg: removes the backdrop blob and ground shape so the background is fully transparent, and remaps the remaining colours to the palette used by the existing *-dark illustrations (#263238 -> #3E535D, #F5F5F5/#EBEBEB -> #333333, #E0E0E0 -> #666666). - Use the dark variant in the search modal for prefers-color-scheme: dark and for the dark theme ([data-themes*=dark]), following the same pattern as files.scss. Ticket: 6933
psawalka
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unified search empty state replaces the magnify icon with the cautious-dog illustration. Unlike the other decorative images (e.g. the mouse in the files view), it had no dark variant, so in dark mode it was shown with its light grey backdrop blob and ground, which made the background look not fully transparent.
Ticket: 6933