Conversation
Since nodejs#4472, clcache keeps its cache in C:\clcache_dir, and nothing uses %USERPROFILE%\clcache any more. The old directory may still hold up to its 20 GB limit on each worker, and the Windows workers have been hitting low-disk alerts and "Failed to create a temp file" failures since that change landed. Delete it at the start of every compile, outside the clcache block, so that the first build of any kind on each worker removes it, including ClangCL builds that never enter that block. The check is a no-op once the directory is gone, and this line can be reverted after every worker has run a build. Refs: nodejs#4477 Refs: nodejs#4472 Assisted-by: Claude Code Signed-off-by: Yasunobu <42543015+P4suta@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #4477
#4472 left the old
%USERPROFILE%\clcachebehind, possibly up to 20 GB per worker.Since then the Windows workers have been running out of disk: every reliability report from September 20 to September 24 lists 8–16 PRs failing with
Failed to create a temp file on C:\workspace\..., and earlier reports list none.The latest report, for September 25, has none, but low-disk alerts are still firing.
This deletes the old directory on every compile, so no one has to clean the workers by hand.
It sits outside the clcache block because the failing builds are all ClangCL, which never enter it.
It is a no-op once the directory is gone, and can be reverted later.
I checked it on Windows 11 against
compile.cmdwith a stubbedvcbuild.bat: it deletes the directory, does nothing when the directory is absent, and never stops the build.I can't see the workers, so I don't know how large the old directory really is.
Assisted by Claude Code; I reviewed and verified everything myself.