Repository navigation
lookup: skip >24 for crc32-stream - #1210
Closed
MikeMcC399 wants to merge 1 commit into
Closed
MikeMcC399 wants to merge 1 commit into
MikeMcC399 wants to merge 1 commit into
Conversation
Signed-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1210 +/- ##
=======================================
Coverage 96.20% 96.20%
=======================================
Files 29 29
Lines 2213 2213
=======================================
Hits 2129 2129
Misses 84 84 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 tasks done
Contributor
Author
|
I accidentally pushed this to Unfortunately it's not possible to change the source branch of a PR, only the destination branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crc32-streamfails on Node.js 26 #1172Situation
Running
citgm crc32-streamfails on Node.js 26.The latest crc32-stream@7.0.1 release was published 2 years ago. The source repo https://github.com/archiverjs/node-crc32-stream shows that the last commit to the default branch was also 2 years old. Renovate continues to run against the repo and there are 11 queued PRs waiting for human intervention.
The designated maintainer ctalkington has not responded to the report of incompatibility with Node.js 26 and they show almost no activity in GitHub in the years 2025 and 2026 following the last release.
They also did not so far respond to the comment archiverjs/node-crc32-stream#139 (comment) suggesting merge of the Renovate
mocha@11update.Assessment
The incompatibility with Node.js 26 is solely a test issue caused by an outdated version of
mocha. PR archiverjs/node-crc32-stream#139 opened in Dec 2024 by Renovate would resolve the Node.js 26 test incompatibility, since it proposes to update tomocha@11.8.0. This is a major version update and Renovate hasautomergedisabled by default for such updates, and thus it is still waiting for human intervention.The package has significant weekly download volumes of around 50M / week, so there is some value in retaining regression testing for
crc32-streamagainst Node.js 22 & 24 until Node.js 24 reaches EOL status on 2028-04-30.Change
Add Node.js >24 skip for
crc32-streamin lookup.json.Checklist
npm testpasseshere