Skip to content

fix(html): fix the version picker on section pages and it blank state - #1112

Open
ryzrr wants to merge 1 commit into
nodejs:mainfrom
ryzrr:fix/version-picker-section
Open

fix(html): fix the version picker on section pages and it blank state#1112
ryzrr wants to merge 1 commit into
nodejs:mainfrom
ryzrr:fix/version-picker-section

Conversation

@ryzrr

@ryzrr ryzrr commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

Description

The version picker on section pages linked to paths like latest-v24.x/api/fs/callback-api.html which exist in no release, so it now points at the module page and keeps the current version selected.

Validation

Simulated the dropdown .

Related Issues

Live on https://beta.docs.nodejs.org/fs/callback-api pick any version and you get a 404

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run node --run test and all tests passed.
  • I have check code formatting with node --run format:check & node --run lint.
  • I've covered new added functionality with unit tests if necessary.

@ryzrr
fix(html): point the version picker at the module page on section pages
885df6c 
Section pages exist only on the new site, so switching versions from /fs/callback-api gave a 404 on every release. The picker now also keeps the current version selected, so it no longer renders empty after going back.

Signed-off-by: Nikhil Kumar Rajak <ryzrr.official@gmail.com>
@ryzrr
ryzrr requested a review from a team as a code owner September 27, 2026 14:24
@vercel

vercel Bot commented Sep 27, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
api-docs-tooling Ready Ready Preview Sep 27, 2026 2:25pm UTC

Request Review

@codecov

codecov Bot commented Sep 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.38%. Comparing base (6a73fd2) to head (885df6c).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1112   +/-   ##
=======================================
  Coverage   91.38%   91.38%           
=======================================
  Files         249      249           
  Lines       23253    23253           
  Branches     2244     2244           
=======================================
  Hits        21250    21250           
  Misses       1994     1994           
  Partials        9        9

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

api-links Generator

Output: 1 file differs

apilinks.json 
Expected values to be strictly deep-equal:
+ actual - expected
... Skipped lines

  {
    'Agent.defaultMaxSockets': 'https://github.com/{repository}/blob/HEAD/lib/_http_agent.js#L300',
    'Buffer.alloc': 'https://github.com/{repository}/blob/HEAD/lib/buffer.js#L453',
    'Buffer.allocUnsafe': 'https://github.com/{repository}/blob/HEAD/lib/buffer.js#L472',
    'Buffer.allocUnsafeSlow': 'https://github.com/{repository}/blob/HEAD/lib/buffer.js#L495',
...
    'agent.addRequest': 'https://github.com/{repository}/blob/HEAD/lib/_http_agent.js#L365',
+   'agent.createConnection': 'https://github.com/{repository}/blob/HEAD/lib/https.js#L354',
-   'agent.createConnection': 'https://github.com/{repository}/blob/HEAD/lib/_http_agent.js#L304',
    'agent.createSocket': 'https://github.com/{repository}/blob/HEAD/lib/_http_agent.js#L446',
    'agent.destroy': 'https://github.com/{repository}/blob/HEAD/lib/_http_agent.js#L679',
+   'agent.getName': 'https://github.com/{repository}/blob/HEAD/lib/https.js#L537',
+   'agent.keepSocketAlive': 'https://github.com/{repository}/blob/HEAD/lib/https.js#L506',
-   'agent.getName': 'https://github.com/{repository}/blob/HEAD/lib/_http_agent.js#L334',
-   'agent.keepSocketAlive': 'https://github.com/{repository}/blob/HEAD/lib/_http_agent.js#L635',
    'agent.removeSocket': 'https://github.com/{repository}/blob/HEAD/lib/_http_agent.js#L574',
    'agent.reuseSocket': 'https://github.com/{repository}/blob/HEAD/lib/_http_agent.js#L671',
    'assert.assert': 'https://github.com/{repository}/blob/HEAD/lib/assert.js#L185',
    'asyncResource.asyncId': 'https://github.com/{repository}/blob/HEAD/lib/async_hooks.js#L243',
    'asyncResource.bind': 'https://github.com/{repository}/blob/HEAD/lib/async_hooks.js#L275',
...
    'server.address': 'https://github.com/{repository}/blob/HEAD/lib/net.js#L2776',
+   'server.close': 'https://github.com/{repository}/blob/HEAD/lib/net.js#L2909',
+   'server.closeAllConnections': 'https://github.com/{repository}/blob/HEAD/lib/https.js#L125',
+   'server.closeIdleConnections': 'https://github.com/{repository}/blob/HEAD/lib/https.js#L127',
-   'server.close': 'https://github.com/{repository}/blob/HEAD/lib/_http_server.js#L694',
-   'server.closeAllConnections': 'https://github.com/{repository}/blob/HEAD/lib/_http_server.js#L704',
-   'server.closeIdleConnections': 'https://github.com/{repository}/blob/HEAD/lib/_http_server.js#L716',
    'server.getConnections': 'https://github.com/{repository}/blob/HEAD/lib/net.js#L2871',
    'server.listen': 'https://github.com/{repository}/blob/HEAD/lib/net.js#L2566',
    'server.ref': 'https://github.com/{repository}/blob/HEAD/lib/net.js#L3023',
+   'server.setTimeout': 'https://github.com/{repository}/blob/HEAD/lib/https.js#L129',
-   'server.setTimeout': 'https://github.com/{repository}/blob/HEAD/lib/_http_server.js#L732',
    'server.unref': 'https://github.com/{repository}/blob/HEAD/lib/net.js#L3032',
+   'server[SymbolAsyncDispose]': 'https://github.com/{repository}/blob/HEAD/lib/net.js#L2950',
-   'server[SymbolAsyncDispose]': 'https://github.com/{repository}/blob/HEAD/lib/_http_server.js#L700',
    'server[SymbolAsyncIterator]': 'https://github.com/{repository}/blob/HEAD/lib/net.js#L2957',
    'server[kDeserialize]': 'https://github.com/{repository}/blob/HEAD/lib/net.js#L2487',
    'server[kTransferList]': 'https://github.com/{repository}/blob/HEAD/lib/net.js#L2459',
    'server[kTransfer]': 'https://github.com/{repository}/blob/HEAD/lib/net.js#L2464',
+   'server[undefined]': 'https://github.com/{repository}/blob/HEAD/lib/net.js#L2987',
-   'server[undefined]': 'https://github.com/{repository}/blob/HEAD/lib/_http_server.js#L739',
    'serverresponse._finish': 'https://github.com/{repository}/blob/HEAD/lib/_http_server.js#L259',
    'serverresponse._implicitHeader': 'https://github.com/{repository}/blob/HEAD/lib/_http_server.js#L416',
    'serverresponse.assignSocket': 'https://github.com/{repository}/blob/HEAD/lib/_http_server.js#L309',
    'serverresponse.detachSocket': 'https://github.com/{repository}/blob/HEAD/lib/_http_server.js#L320',
    'serverresponse.statusCode': 'https://github.com/{repository}/blob/HEAD/lib/_http_server.js#L282',

Performance estimate (single CI run)

  • Generation time: 36.2% faster (1.41 s → 900.00 ms)
  • Peak memory: 4.5% higher (412.92 MB → 431.58 MB)

json Generator

Performance estimate (single CI run)

  • Generation time: 0.5% faster (9.14 s → 9.09 s)
  • Peak memory: 0.3% lower (1.69 GB → 1.68 GB)

legacy-html Generator

Performance estimate (single CI run)

  • Generation time: 22.6% faster (43.22 s → 33.45 s)
  • Peak memory: 3.5% higher (2.44 GB → 2.52 GB)

legacy-json Generator

Performance estimate (single CI run)

  • Generation time: 10.1% slower (8.01 s → 8.82 s)
  • Peak memory: 4.1% lower (1.74 GB → 1.67 GB)

llms-txt Generator

Performance estimate (single CI run)

  • Generation time: 8.2% slower (5.52 s → 5.97 s)
  • Peak memory: 7.9% lower (1.57 GB → 1.45 GB)

orama-db Generator

Output size: 1 file changed · net +2.00 B

File size details
File Main PR Change
orama-db.json 9.50 MB 9.50 MB +2.00 B (+0.0%)

Performance estimate (single CI run)

  • Generation time: 69.6% slower (4.96 s → 8.41 s)
  • Peak memory: 13.1% lower (1.77 GB → 1.54 GB)

web Generator

Output size: 126 files changed · net -1.92 KB

File size details
File Main PR Change
assets/SearchBox-xWxQEwJG.js 84.60 KB — -84.60 KB (-100.0%)
assets/SearchBox-CzHQdS75.js — 84.60 KB +84.60 KB
assets/dist-B6Cxpm1h.js 30.42 KB — -30.42 KB (-100.0%)
assets/dist-X9duL2wG.js — 30.42 KB +30.42 KB
assets/SideBar-CqzxeelS.js — 25.72 KB +25.72 KB
assets/SideBar-CXDS9lwB.js 25.64 KB — -25.64 KB (-100.0%)
assets/client-Dq0Q6MAq.js 21.59 KB — -21.59 KB (-100.0%)
assets/client-DboRSglV.js — 21.59 KB +21.59 KB
assets/Combination-CHXR84A0.js 16.12 KB — -16.12 KB (-100.0%)
assets/Combination-VZ1CN5FT.js — 16.12 KB +16.12 KB
assets/ThemeToggle-DDz9c6ru.js 13.64 KB — -13.64 KB (-100.0%)
assets/ThemeToggle-FTWpqJUE.js — 13.64 KB +13.64 KB
assets/dist-B8-MMbUy.js 10.20 KB — -10.20 KB (-100.0%)
assets/dist-Ca7ddWHG.js — 10.20 KB +10.20 KB
assets/Layout-CUfyk3qZ.js 10.14 KB — -10.14 KB (-100.0%)
assets/Layout-BKADeNJr.js — 10.14 KB +10.14 KB
assets/compat-BOvxfbHG.js 10.12 KB — -10.12 KB (-100.0%)
assets/compat-CP7C4UZZ.js — 10.12 KB +10.12 KB
assets/Tooltip-CCL7e45H.js 7.93 KB — -7.93 KB (-100.0%)
assets/Tooltip-IOooGSuI.js — 7.93 KB +7.93 KB
assets/dist-vvnfrFEG.js 6.99 KB — -6.99 KB (-100.0%)
assets/dist-DEFadIVs.js — 6.99 KB +6.99 KB
assets/jsx-runtime-Suavd6wv.js 5.67 KB — -5.67 KB (-100.0%)
assets/jsx-runtime-BGcB4va8.js — 5.67 KB +5.67 KB
assets/dist-CW18yqev.js 3.94 KB — -3.94 KB (-100.0%)
assets/dist-uGO0lJvt.js — 3.94 KB +3.94 KB
assets/CodeTabs-Bddfa2sD.js 3.89 KB — -3.89 KB (-100.0%)
assets/CodeTabs-Ck9cVOnL.js — 3.89 KB +3.89 KB
assets/CodeBox-nTFnhk5t.js 3.44 KB — -3.44 KB (-100.0%)
assets/CodeBox-Yo9cMzix.js — 3.44 KB +3.44 KB
assets/hooks.module-s9wfDDNr.js 3.40 KB — -3.40 KB (-100.0%)
assets/hooks.module-Df2UBsCP.js — 3.40 KB +3.40 KB
assets/FunctionSignature-BEojS7IQ.js 2.28 KB — -2.28 KB (-100.0%)
assets/FunctionSignature-zZUfJtoa.js — 2.28 KB +2.28 KB
assets/Banner-DlFTTX0X.js 2.19 KB — -2.19 KB (-100.0%)
assets/Banner-CZR6PWMd.js — 2.19 KB +2.19 KB
assets/ChangeHistory-BX3eIUtk.js 1.77 KB — -1.77 KB (-100.0%)
assets/ChangeHistory-CMJes_Vb.js — 1.77 KB +1.77 KB
assets/DataTag-C8_euUlY.js 844.00 B — -844.00 B (-100.0%)
assets/DataTag-Dw6p4EBG.js — 844.00 B +844.00 B
assets/DocumentationIndex-DwduBlD_.js 833.00 B — -833.00 B (-100.0%)
assets/DocumentationIndex-ANfuV--A.js — 833.00 B +833.00 B
assets/ArrowUpRightIcon-BbHDY9iR.js 618.00 B — -618.00 B (-100.0%)
assets/ArrowUpRightIcon-B5C_MFnA.js — 618.00 B +618.00 B
assets/Badge-Dox463y7.js 607.00 B — -607.00 B (-100.0%)
assets/Badge-DTw0EMDK.js — 607.00 B +607.00 B
assets/AlertBox-8KlJ1j1V.js 591.00 B — -591.00 B (-100.0%)
assets/AlertBox-BwGZv9Xn.js — 591.00 B +591.00 B
assets/CodeBracketIcon-YqUexKPH.js 512.00 B — -512.00 B (-100.0%)
assets/CodeBracketIcon-6LQikJmF.js — 512.00 B +512.00 B
assets/dist-Bxf_F6I7.js 477.00 B — -477.00 B (-100.0%)
assets/dist-iy4AItKU.js — 477.00 B +477.00 B
assets/ChevronDownIcon-H-5RUINM.js 468.00 B — -468.00 B (-100.0%)
assets/ChevronDownIcon-zYfy93kr.js — 468.00 B +468.00 B
assets/Blockquote-BQu1Urbw.js 167.00 B — -167.00 B (-100.0%)
assets/Blockquote-BWzIwLBr.js — 167.00 B +167.00 B
assets/withIsland-EGolLQug.js 105.00 B — -105.00 B (-100.0%)
assets/withIsland-Cufwl80V.js — 105.00 B +105.00 B
404.html 21.90 KB 21.87 KB -30.00 B (-0.1%)
addons.html 379.19 KB 379.16 KB -30.00 B (-0.0%)
all.html 32.86 MB 32.86 MB -30.00 B (-0.0%)
assert.html 650.82 KB 650.79 KB -30.00 B (-0.0%)
async_context.html 318.34 KB 318.31 KB -30.00 B (-0.0%)
async_hooks.html 283.61 KB 283.58 KB -30.00 B (-0.0%)
buffer.html 1.74 MB 1.74 MB -30.00 B (-0.0%)
child_process.html 674.81 KB 674.78 KB -30.00 B (-0.0%)
cli.html 613.81 KB 613.78 KB -30.00 B (-0.0%)
cluster.html 302.74 KB 302.71 KB -30.00 B (-0.0%)
console.html 185.16 KB 185.13 KB -30.00 B (-0.0%)
crypto.html 1.96 MB 1.96 MB -30.00 B (-0.0%)
debugger.html 143.46 KB 143.43 KB -30.00 B (-0.0%)
deprecations.html 561.21 KB 561.18 KB -30.00 B (-0.0%)
dgram.html 299.77 KB 299.74 KB -30.00 B (-0.0%)
diagnostics_channel.html 529.83 KB 529.80 KB -30.00 B (-0.0%)
dns.html 421.90 KB 421.87 KB -30.00 B (-0.0%)
documentation.html 28.55 KB 28.52 KB -30.00 B (-0.1%)
domain.html 126.91 KB 126.88 KB -30.00 B (-0.0%)
embedding.html 60.54 KB 60.51 KB -30.00 B (-0.0%)
environment_variables.html 37.69 KB 37.66 KB -30.00 B (-0.1%)
errors.html 530.83 KB 530.80 KB -30.00 B (-0.0%)
esm.html 187.11 KB 187.08 KB -30.00 B (-0.0%)
events.html 833.58 KB 833.55 KB -30.00 B (-0.0%)
fs.html 2.21 MB 2.21 MB -30.00 B (-0.0%)
globals.html 281.22 KB 281.19 KB -30.00 B (-0.0%)
http.html 1.10 MB 1.10 MB -30.00 B (-0.0%)
http2.html 1.25 MB 1.25 MB -30.00 B (-0.0%)
https.html 240.53 KB 240.50 KB -30.00 B (-0.0%)
index.html 26.74 KB 26.71 KB -30.00 B (-0.1%)
inspector.html 213.90 KB 213.87 KB -30.00 B (-0.0%)
intl.html 56.42 KB 56.39 KB -30.00 B (-0.1%)
module.html 510.36 KB 510.33 KB -30.00 B (-0.0%)
modules.html 227.47 KB 227.44 KB -30.00 B (-0.0%)
n-api.html 1.00 MB 1.00 MB -30.00 B (-0.0%)
net.html 633.42 KB 633.39 KB -30.00 B (-0.0%)
os.html 164.88 KB 164.85 KB -30.00 B (-0.0%)
packages.html 218.57 KB 218.54 KB -30.00 B (-0.0%)
path.html 177.30 KB 177.27 KB -30.00 B (-0.0%)
perf_hooks.html 837.81 KB 837.78 KB -30.00 B (-0.0%)
permissions.html 76.81 KB 76.78 KB -30.00 B (-0.0%)
process.html 1.14 MB 1.14 MB -30.00 B (-0.0%)
punycode.html 64.84 KB 64.82 KB -30.00 B (-0.0%)
querystring.html 66.98 KB 66.95 KB -30.00 B (-0.0%)
quic.html 924.12 KB 924.09 KB -30.00 B (-0.0%)
readline.html 363.68 KB 363.65 KB -30.00 B (-0.0%)
repl.html 302.99 KB 302.96 KB -30.00 B (-0.0%)
report.html 231.18 KB 231.15 KB -30.00 B (-0.0%)
single-executable-applications.html 159.51 KB 159.48 KB -30.00 B (-0.0%)
sqlite.html 519.94 KB 519.91 KB -30.00 B (-0.0%)
stream.html 1.22 MB 1.22 MB -30.00 B (-0.0%)
stream_iter.html 732.37 KB 732.34 KB -30.00 B (-0.0%)
string_decoder.html 66.22 KB 66.19 KB -30.00 B (-0.0%)
test.html 1.36 MB 1.36 MB -30.00 B (-0.0%)
timers.html 182.85 KB 182.82 KB -30.00 B (-0.0%)
tls.html 523.79 KB 523.77 KB -30.00 B (-0.0%)
tracing.html 126.07 KB 126.04 KB -30.00 B (-0.0%)
tty.html 107.25 KB 107.22 KB -30.00 B (-0.0%)
typescript.html 50.26 KB 50.23 KB -30.00 B (-0.1%)
url.html 512.50 KB 512.47 KB -30.00 B (-0.0%)
util.html 1.20 MB 1.20 MB -30.00 B (-0.0%)
v8.html 550.54 KB 550.51 KB -30.00 B (-0.0%)
vm.html 633.52 KB 633.49 KB -30.00 B (-0.0%)
wasi.html 80.33 KB 80.30 KB -30.00 B (-0.0%)
webcrypto.html 640.64 KB 640.62 KB -30.00 B (-0.0%)
webstreams.html 535.38 KB 535.35 KB -30.00 B (-0.0%)
worker_threads.html 634.84 KB 634.81 KB -30.00 B (-0.0%)
zlib.html 947.59 KB 947.56 KB -30.00 B (-0.0%)

Performance estimate (single CI run)

  • Generation time: 40.5% slower (45.46 s → 63.86 s)
  • Peak memory: 4.8% higher (3.47 GB → 3.63 GB)

This branch was successfully deployed

1 active deployment
Preview – api-docs-tooling — 885df6cc Deployed Sep 27, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ryzrr @AugustinMauroy