Repository navigation
Conversation
|
Review requested:
|
d0750bf to
140cde3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62724 +/- ##
==========================================
- Coverage 92.99% 90.70% -2.30%
==========================================
Files 428 797 +369
Lines 195633 278898 +83265
Branches 30281 53637 +23356
==========================================
+ Hits 181937 252967 +71030
- Misses 13369 16302 +2933
- Partials 327 9629 +9302
🚀 New features to boost your workflow:
|
140cde3 to
abc640a
Compare
|
CI is very red |
abc640a to
fedc05d
Compare
|
Thanks @mcollina! Fixed, all workflows are finally back to green! Feel free to take a look whenever you have a chance. |
a93485a to
e5e76a2
Compare
|
@mcollina I've reworked the approach now just suppressing the warnings with compiler pragmas instead of migrating APIs. Test file is fully untouched, all fe80:: cases preserved. Full API migration will be a follow-up PR. |
e5e76a2 to
8014a4d
Compare
|
@thisalihassan Great catches, all valid. I've force-pushed a new approach just pragma-based warning suppression (13 lines, 1 file). No API migration, so the IPv6 link-local and CNAME-TTL clamping issues are gone. Signed-off-by added. Full migration can be a separate PR. |
|
Hi @mcollina following up on this. I've addressed all feedback from your
The full migration to Could you dismiss the "changes requested" state and re-review when you get @targos this addresses the deprecation warnings you reported in #52464. |
64b6870 to
3616cdb
Compare
|
@targos Thanks for the feedback reworked! The PR now fully migrates all reply-parser APIs to |
|
This pull request has been marked as stale due to 90 days of inactivity. |
|
Keep this open |
3616cdb to
c99ebf2
Compare
Documents migration of deprecated c-ares reply parsing and server configuration APIs to modern replacements. Fixes: nodejs#52464 Assisted-by: Antigravity Signed-off-by: om-ghante <mr.omghante1@gmail.com>
This PR migrates the deprecated c-ares reply-parsing APIs in
src/cares_wrap.ccto the modernares_dns_parse/ares_dns_record_tAPI family, replacing ~10 deprecated call sites (ares_parse_a_reply,ares_parse_aaaa_reply,ares_parse_ns_reply,ares_parse_ptr_reply,ares_parse_mx_reply,ares_parse_caa_reply,ares_parse_txt_reply_ext,ares_parse_srv_reply,ares_parse_naptr_reply,ares_parse_soa_reply) with their modern equivalents while preserving CNAME-TTL clamping behavior.The server management functions (
EnsureServers,GetServers,SetServers) retain the originalares_get_servers_ports/ares_set_servers_portsAPIs with targeted pragma suppression, as the modern CSV alternatives (ares_get_servers_csv,ares_set_servers_ports_csv) silently drop IPv6 link-local addresses.Fixes: #52464