Repository navigation
Conversation
Collaborator
|
Review requested:
|
Author
|
Follow-up commit on this branch: also include RFC 6598 CGNAT ( Same unreleased-API helper surface as the |
jasnell
approved these changes
Aug 11, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65204 +/- ##
==========================================
+ Coverage 90.31% 90.68% +0.36%
==========================================
Files 760 797 +37
Lines 248532 279582 +31050
Branches 46908 53781 +6873
==========================================
+ Hits 224467 253530 +29063
- Misses 15505 16343 +838
- Partials 8560 9709 +1149
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Aug 24, 2026
Collaborator
This comment was marked as resolved.
This comment was marked as resolved.
PRIVATE_RANGES covers private, loopback, and link-local ranges. It already includes 127.0.0.0/8 and ::1/128, and left out the IPv4 "this" network (0.0.0.0/8) and the IPv6 unspecified address (::/128). Those are common localhost spellings. Signed-off-by: Sasha Mitchell <sash.t.mitchell@gmail.com>
Include RFC 6598 (100.64.0.0/10) and RFC 2544 (198.18.0.0/15). The helper then matches the non-global IPv4 space used by carrier NAT and benchmarking labs. Signed-off-by: Sasha Mitchell <sash.t.mitchell@gmail.com>
SashaMIT
force-pushed
the
fix/blocklist-private-ranges-unspecified
branch
from
November 7, 2026 16:56
e8d6fba to
14f0973
Compare
Author
|
Thanks for the pointer. Both commits are signed off and the body lines are wrapped to 72 columns. The tip is 14f0973. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BlockList.PRIVATE_RANGESis documented as a convenience list of private, loopback, and link-local ranges for blocking non-routable addresses. It already includes127.0.0.0/8and::1/128, but omitted:0.0.0.0/8(IPv4 "this" network / unspecified; common alternate localhost spelling)::/128(IPv6 unspecified)Callers who populate a blocklist from
PRIVATE_RANGESalone would still treat0.0.0.0and::as allowed.Test plan
test/parallel/test-blocklist.jsPRIVATE_RANGES coverage for0.0.0.0,0.0.0.1, and::doc/api/net.mdThis API is unreleased (
added: REPLACEME), so this is a constants/docs completion rather than a HackerOne report.Made with Cursor