Repository navigation
worker: emit worker exit notifications on BroadcastChannel - #65575
SudhansuBandha wants to merge 5 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65575 +/- ##
==========================================
+ Coverage 90.71% 90.72% +0.01%
==========================================
Files 801 801
Lines 280705 280771 +66
Branches 54168 54174 +6
==========================================
+ Hits 254640 254728 +88
+ Misses 16247 16213 -34
- Partials 9818 9830 +12
🚀 New features to boost your workflow:
|
4dd297f to
d8a79bf
Compare
f23efdb to
b1c9fb9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
b1c9fb9 to
f3007df
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
@MikeMcC399 I have not received any failure on my Windows machine because of my changes in PR. Can you provide me a suitable approach where I can recreate the CI failure on Windows machine. Will WSL/MSYS2 help in this regards? |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
Thank you @MikeMcC399 for your help. I believe I have missed a failing test in my changes which I am currently looking at it. Hopefully CI issues will get resolved after this. |
c1b0497 to
ccc39ae
Compare
|
@MikeMcC399 I have fixed the failing test but still the CI issue is not getting resolved. If it is possible, can you or anyone else debug these failing CI issues against the test suite on Linux/MacOs. I am not able to reproduce on Windows and due to limited hardware resources it is difficult for me to have a dual setup of Windows and Linux on my machine |
|
I'm sorry, I won't be able to help you further with the test problems. |
83e569e to
c0f9084
Compare
|
@MikeMcC399 CI looks to be good for now. Hope that we can take this further!!!😄 |
Perhaps @addaleax will be able to review again now that your tests are succeeding? |
I am also hopeful for the same!! |
|
Hey @addaleax , hope all is good. As per your feedback, suggested changes are implemented. CI is also good. Do review them whenever you have a moment and let me know if there needs any improvement. |
c0f9084 to
bdcce46
Compare
bdcce46 to
3231711
Compare
Expose worker termination notifications through BroadcastChannel so consumers can observe when a worker exits andinspect its thread ID and exit code. Fixes: nodejs#59053 Signed-off-by: SudhansuBandha <bandhasudhansu@gmail.com>
3231711 to
59dac08
Compare
|
Hi, wanted to check if this PR could get some movement. @jasnell, given your prior work on BroadcastChannel, would you be willing to take a look whenever you have a moment? All previous feedback has been addressed and the branch is rebased. |
| --> | ||
|
|
||
| * Type: {Function} Invoked when worker associated with the | ||
| `BroadcastChannel` terminates. |
There was a problem hiding this comment.
Is the use case for this primarily diagnostic? If so, I wonder if a diagnostic channel event would be better?
There was a problem hiding this comment.
For now, primary consumers are most likely APM/observability tools like Prometheus (as described in the original issue), diagnostics channel event does seem to be a good fit. I’m less familiar with the conventions around diagnostics channel, so I’d welcome your guidance for the correct approach to take this forward.
Expose worker termination notifications through BroadcastChannel so consumers can observe when a worker exits and inspect its thread ID and exit code.
Fixes: #59053