Conversation
|
Review requested:
|
c7993ad to
50ef480
Compare
50ef480 to
52ba7ce
Compare
jasnell
left a comment
There was a problem hiding this comment.
While the status is still unclear, and it's not certain at all that'll it will make progress, it is still considered an active TC-39 proposal. Removing entirely may be premature. Won't block but I also don't agree with removing it just yet.
|
Technically the proposal was moved to stage 2.7, and not moved yet stage 3 back again for implementation. We could add it back when it gets promoted to stage 3 again. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65650 +/- ##
==========================================
+ Coverage 90.29% 90.33% +0.04%
==========================================
Files 790 787 -3
Lines 272883 272731 -152
Branches 52118 52079 -39
==========================================
- Hits 246387 246377 -10
+ Misses 16943 16841 -102
+ Partials 9553 9513 -40
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
mcollina
left a comment
There was a problem hiding this comment.
We might want to wait until the next TC39 (I think it's later this month), and if nothing is moving still, we should remove it unless we get some alternative guidance from them.
The TC39 ShadowRealm proposal remains unimplemented by browsers, and WPT removed ShadowRealm test coverage. Remove the Node.js host integration, the --experimental-shadow-realm CLI flag, and related tests. Refs: web-platform-tests/wpt#59794 Refs: nodejs#42528 Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com> Co-authored-by: Yagiz Nizipli <anonrig@users.noreply.github.com>
52ba7ce to
eff3e1a
Compare
|
Rebased onto current main ( @legendecas agreed, we can put it back if this reaches stage 3 again. It's 2.7 right now. @mcollina the next meeting is 29 Sep–1 Oct in Tokyo. This push is just to get the branch current. Not trying to land it ahead of that. @jasnell I get why this feels early while the proposal is still active. Leaving it open so we can decide after the meeting. |
This removes experimental
ShadowRealmsupport from Node.js.The TC39 ShadowRealm proposal remains unimplemented by browsers. WPT dropped ShadowRealm test coverage in web-platform-tests/wpt#59794 because the tests added significant noise without implementer support.
This PR:
--experimental-shadow-realmflag and the--harmony-shadow-realmV8 option aliasnode_shadow_realm.*, isolate callback, bootstrap)--experimental-shadow-realmwas never enabled by default and never left experimental status.Refs: web-platform-tests/wpt#59794
Refs: #42528
This change was prepared with assistance from an AI coding agent.