Repository navigation
diagnostics_channel: add threadpool work event - #65982
Merged
Merged
Conversation
Collaborator
|
Review requested:
|
IlyasShabi
force-pushed
the
ishabi/threadpool-dc
branch
from
September 11, 2026 13:19
b6fb403 to
946f372
Compare
Member
Author
|
@mcollina You mean separate channels named |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65982 +/- ##
==========================================
+ Coverage 90.66% 90.68% +0.02%
==========================================
Files 799 799
Lines 280252 280319 +67
Branches 54121 54136 +15
==========================================
+ Hits 254088 254215 +127
+ Misses 16285 16218 -67
- Partials 9879 9886 +7
🚀 New features to boost your workflow:
|
Member
|
yes |
IlyasShabi
force-pushed
the
ishabi/threadpool-dc
branch
from
September 14, 2026 09:41
3e589e0 to
ff193a0
Compare
Member
|
I think you are missing the documentation |
Member
Author
|
I added some doc to https://github.com/nodejs/node/pull/65982/changes#diff-d9c2d2d884d1dea00c82e7f00176441f9524573b6429fd83bf3835cd09a5b029R2029 could you point me to the missing doc? |
Member
Author
|
@mcollina could you please have a look? |
IlyasShabi
force-pushed
the
ishabi/threadpool-dc
branch
from
October 6, 2026 09:26
ff193a0 to
a1c60b9
Compare
bengl
reviewed
Oct 6, 2026
IlyasShabi
force-pushed
the
ishabi/threadpool-dc
branch
from
October 9, 2026 08:54
a1c60b9 to
8b8372f
Compare
Qard
approved these changes
Oct 13, 2026
Member
Author
|
@mcollina could you please check? |
bengl
approved these changes
Oct 13, 2026
Collaborator
Signed-off-by: ishabi <ilyasshabi94@gmail.com>
IlyasShabi
force-pushed
the
ishabi/threadpool-dc
branch
from
November 16, 2026 13:59
8b8372f to
0e550b7
Compare
Collaborator
Collaborator
|
Landed in 6a536f9 |
aduh95
pushed a commit
that referenced
this pull request
Nov 19, 2026
Signed-off-by: ishabi <ilyasshabi94@gmail.com> PR-URL: #65982 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to add support for experimental
threadpool.work.<type>diagnostics channel.type: kind of threadpool workThe event exposes:
enqueued: submission timestampstarted: execution start timestampended: execution end timestampThese timestamps allow diagnostics tools to distinguish queue time from native execution time. Cancelled work reports
startedandendedasnull.The channel and subscriber state are cached per
Environmentso the unsubscribed path remains minimal.Benchmark
Unsubscribed configurations showed no significant regressions. Most subscribed configurations were also within noise;
zlibatn=10000measured a 3.48% regression on local machine (will share the onces from CI)