Repository navigation
test_runner: junit fixes - #67160
test_runner: junit fixes#67160
Conversation
Signed-off-by: avivkeller <me@aviv.sh>
|
Review requested:
|
avivkeller
left a comment
There was a problem hiding this comment.
This was not meant to be a draft...
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67160 +/- ##
==========================================
- Coverage 90.69% 90.67% -0.03%
==========================================
Files 797 800 +3
Lines 278787 280543 +1756
Branches 53607 54184 +577
==========================================
+ Hits 252858 254386 +1528
+ Misses 16292 16277 -15
- Partials 9637 9880 +243
🚀 New features to boost your workflow:
|
| node.attrs.classname = 'test'; | ||
| node.attrs.failure = message; | ||
| ArrayPrototypePush(node.children, { | ||
| __proto__: null, nesting: node.nesting + 1, tag: 'failure', |
There was a problem hiding this comment.
Nit, use __proto__: kEmptyObject (kEmptyObject is in internal/util) to keep the object in fast-properties mode.
| closeUnfinished(event.data.nesting); | ||
| const originalSuite = currentSuite; | ||
| currentSuite = { | ||
| __proto__: null, |
There was a problem hiding this comment.
since you're in here making changes anyway, might be worthwhile switching this to __proto__: kEmptyObject. Worth checking.
Commit Queue failedThis pull request has multiple commits, but no landing policy was selected. Add
commit-queue-squash
The pull request was removed from the Commit Queue and labeled
commit-queue-failed
Full Commit Queue output |
|
Landed in 030745c |
Fixes: #67155
Fixes: #67149
Adds sanitization + flushing to the Junit reporter, fixing the aforementioned issues.
Signed-off-by: avivkeller me@aviv.sh