Skip to content

tls: pop errors from failed session parsing - #67212

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lazerg:fix/issue-67204-tls-session-errors
Nov 14, 2026
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lazerg:fix/issue-67204-tls-session-errors

Conversation

@lazerg

@lazerg lazerg commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

When d2i_SSL_SESSION() fails to parse a session passed to tls.connect() or setSession(), its errors stay on the OpenSSL error queue, and a later unrelated crypto call reports them instead of its own error. This pops them in GetTLSSession(), which also covers the QUIC session ticket path.

Fixes: #67204

Signed-off-by: lazerg <lazerg2@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Caution

AgentScan found account activity patterns that may be consistent with automation. This is a heuristic, not proof that this pull request was opened by an agent or violates policy. AI-assisted contributions are permitted, but automated tooling must not open pull requests without advance approval, and contributors must personally understand, test, verify, and take responsibility for every submitted change. See the AgentScan analysis, AI use policy, and automation policy for additional context.

@codecov

codecov Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.71%. Comparing base (96de0e2) to head (fd86a7f).
⚠️ Report is 143 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67212      +/-   ##
==========================================
- Coverage   92.99%   90.71%   -2.29%     
==========================================
  Files         428      797     +369     
  Lines      195633   278885   +83252     
  Branches    30268    53628   +23360     
==========================================
+ Hits       181937   252977   +71040     
- Misses      13369    16256    +2887     
- Partials      327     9652    +9325     
Files with missing lines Coverage Δ
src/crypto/crypto_common.cc 78.68% <100.00%> (ø)

... and 499 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pimterry pimterry added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 12, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 12, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@pimterry pimterry added the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Nov 13, 2026
@github-actions github-actions Bot removed the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Nov 13, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 14, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 52bfcaf into nodejs:main Nov 14, 2026
88 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 52bfcaf

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 14, 2026
aduh95 pushed a commit that referenced this pull request Nov 19, 2026
Signed-off-by: lazerg <lazerg2@gmail.com>
PR-URL: #67212
Fixes: #67204
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agentscan:community-flagged author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tls: TLSSocket session deserialization failure leaves errors on the OpenSSL error queue (wrong error codes in later crypto calls)

5 participants