Repository navigation
perf_hooks: copy shared data before importing histograms - #67249
adityareddy-dev wants to merge 1 commit into
Conversation
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. Caution AgentScan found account activity patterns that may be consistent with automation. This is a heuristic, not proof that this pull request was opened by an agent or violates policy. AI-assisted contributions are permitted, but automated tooling must not open pull requests without advance approval, and contributors must personally understand, test, verify, and take responsibility for every submitted change. See the AgentScan analysis, AI use policy, and automation policy for additional context. |
Copy SharedArrayBuffer-backed input before parsing its CBOR data so concurrent worker writes cannot change the bytes during parsing. Fixes: nodejs#67152 Signed-off-by: Aditya Reddy <82123567+adityareddy-dev@users.noreply.github.com>
d7a5c02 to
52b15ac
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Thanks Mike, that makes sense. Closing this one for now and keeping #67243 open until it lands. |
importHistogram()reads the input several times while parsing CBOR. Copy SharedArrayBuffer-backed input first so concurrent worker writes cannot change the bytes during parsing, following the existing approach inBuffer.toString().Fixes: #67152