Skip to content

doc: mention the request-cves label in the security release process - #67306

Open
UlisesGascon wants to merge 1 commit into
nodejs:mainfrom
UlisesGascon:doc/security-release-request-cves-label
Open

UlisesGascon wants to merge 1 commit into
nodejs:mainfrom
UlisesGascon:doc/security-release-request-cves-label

Conversation

@UlisesGascon

Copy link
Copy Markdown
Member

Documents the request-cves label from nodejs-private/security-release#92 as an alternative to running git node security --request-cve locally.

Refs: nodejs/security-wg#1576

CVE ids can now be reserved from the security release pull request by
adding the `request-cves` label, instead of running
`git node security --request-cve` locally with personal credentials.
Note the label next to the command under 'Requesting CVEs', with the
retry via `request-cves-failed`.

Refs: nodejs/security-wg#1576
Refs: nodejs-private/security-release#92
Refs: nodejs/node-core-utils#1232
Assisted-by: Claude, Codex
Signed-off-by: Ulises Gascon <ulisesgascongonzalez@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-stewards
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Nov 6, 2026

@RafaelGSS RafaelGSS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this can cause some confusion since there are two different ways of requesting cves and they are not the same, one goes to H1 and the second one to OpenJS CNA. Can't we just update the --request-cve?

@UlisesGascon
UlisesGascon marked this pull request as ready for review November 12, 2026 10:15
@UlisesGascon

Copy link
Copy Markdown
Member Author

I feel this can cause some confusion since there are two different ways of requesting cves and they are not the same, one goes to H1 and the second one to OpenJS CNA. Can't we just update the --request-cve?

We did our first release with OpenJS CNA CVEs and worked fine (we need shape things). I kept both options for compatibility/fallback on nodejs/node-core-utils#1232. But I can open a new PR and remove H1 as ncu cve provider 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to Node.js documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants