Repository navigation
build,win: add pgo generate workflow - #67438
StefanStojanovic wants to merge 1 commit into
Conversation
Signed-off-by: StefanStojanovic <stefan.stojanovic@janeasystems.com>
|
Review requested:
|
legendecas
left a comment
There was a problem hiding this comment.
I'm not sure if we want to keep the generated data in the git and the repo history, even if its' not merged into the main branch. For each run and each platform, the generated data seems to be about ~10MB: https://github.com/JaneaSystems/node/actions/runs/42214152931
|
Thanks for your feedback @legendecas. The original idea was to merge them into the branches we use to build releases, but the files are even bigger - a single The workflow is straightforward, so once we agree on the complete PGO flow, I'll modify the last step to push the result where it is expected. |
This PR adds a Windows GitHub action that runs a PGO-instrumented build, executes workload scripts on a runner with the requested architecture (x64 or ARM64), and creates a branch that pushes the
profdatafile to the predefined location in the repository.After the branch is created, you can open a PR to main or an LTS branch to include that change. Once that is done, the release CI will look for that file and use it for the release. This will also make release Windows builds more than twice as fast because the preparation step (instrumented build and workloads) will already be finished. Since we currently use x64-generated
profdatain ARM64 releases, this will further improve performance on ARM64 Windows.I've already tested the workflow in my Node.js fork, and everything worked as expected.
P.S. I've already tested this through the release CI and saw no issues there.