Repository navigation
quic: fix h3 session close on early stream destroy - #67446
Conversation
If the stream is destroyed right after sendHeaders(), nghttp3 still has the response headers queued. On the next write it asks for the removed stream's body, the read callback fails, and the whole session closes without notifying the peer. In an HTTP/3 session, before clearing nghttp3's pointer to a stream when the stream is destroyed, shut down nghttp3's writes for that stream so that other requests can continue to complete. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ethan Arrowood <ethan@arrowood.dev>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67446 +/- ##
==========================================
- Coverage 90.68% 90.68% -0.01%
==========================================
Files 801 801
Lines 281889 281889
Branches 54318 54319 +1
==========================================
- Hits 255645 255641 -4
- Misses 16358 16360 +2
- Partials 9886 9888 +2 🚀 New features to boost your workflow:
|
Commit Queue failedThe pull request was removed from the Commit Queue and labeled
commit-queue-failed
Full Commit Queue output |
|
Landed in 88b034f |
If the stream is destroyed right after sendHeaders(), nghttp3 still has the response headers queued. On the next write it asks for the removed stream's body, the read callback fails, and the whole session closes without notifying the peer. In an HTTP/3 session, before clearing nghttp3's pointer to a stream when the stream is destroyed, shut down nghttp3's writes for that stream so that other requests can continue to complete. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ethan Arrowood <ethan@arrowood.dev> PR-URL: #67446 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com>
|
Sorry, that I comment on a closed PR, but I rebased my yesterday my webtransport PR and it showed that webtransport close capsules are not sent. (These are scheduled right before the session stream is closed). I found the reason here: it prevents already scheduled data in a stream to be sent, including the session close capsule in case of webtransport. That is just my first feedback, I will try to understand why this was added and comeback later. |
If the stream is destroyed right after sendHeaders(), nghttp3 still has the response headers queued. On the next write it asks for the removed stream's body, the read callback fails, and the whole session closes without notifying the peer.
In an HTTP/3 session, before clearing nghttp3's pointer to a stream when the stream is destroyed, shut down nghttp3's writes for that stream so that other requests can continue to complete.
This PR adds regression tests to cover the issue.
Discovered this while reviewing #66007, which adds
stream.cancel(). That PR's cancel-after-headers case depends on this fix. Callingdestroy()without a code still sends no reset, which is out of scope here (continue discussion in #66007).AI-assisted (Claude Opus 5.5, my setup). The words are my own, per the Human Voice policy.