Repository navigation
util: revoke DEP0174 and forward promisify rejections #67489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jasnell
wants to merge
2
commits into
nodejs:main
Choose a base branch
from
jasnell:util-promisify-dep0174
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| 'use strict'; | ||
| // Flags: --no-deprecation | ||
| const common = require('../common'); | ||
| const assert = require('assert'); | ||
| const { promisify } = require('util'); | ||
|
|
||
| // Calling a promisified function that returns a Promise emits a regular | ||
| // warning, once per promisified function. It is not a deprecation warning, so | ||
| // --no-deprecation does not affect it; it can be silenced with | ||
| // --disable-warning=PROMISIFY_RETURNED_PROMISE. | ||
| process.on('warning', common.mustCall((warning) => { | ||
| assert.strictEqual(warning.name, 'Warning'); | ||
| assert.strictEqual(warning.code, 'PROMISIFY_RETURNED_PROMISE'); | ||
| assert.strictEqual( | ||
| warning.message, | ||
| 'Calling promisify on a function that returns a Promise is likely a mistake.'); | ||
| }, 5)); | ||
|
|
||
| // The callback is still used to settle the result, and the warning is only | ||
| // emitted once even when the promisified function is called several times. | ||
| { | ||
| const fn = promisify(async (value, callback) => { callback(null, value); }); | ||
| fn(1).then((value) => assert.strictEqual(value, 1)).then(common.mustCall()); | ||
| fn(2).then((value) => assert.strictEqual(value, 2)).then(common.mustCall()); | ||
| } | ||
|
|
||
| // Errors passed to the callback still reject the result. | ||
| { | ||
| const error = new Error('callback error'); | ||
| assert.rejects(promisify(async (callback) => { callback(error); })(), error) | ||
| .then(common.mustCall()); | ||
| } | ||
|
|
||
| // Rejections of the returned Promise are forwarded instead of being left | ||
| // unhandled. | ||
| { | ||
| const error = new Error('returned promise rejection'); | ||
| assert.rejects(promisify(async () => { throw error; })(), error) | ||
| .then(common.mustCall()); | ||
| } | ||
|
|
||
| // If the callback already settled the result, a later rejection of the | ||
| // returned Promise is still reported as an unhandled rejection rather than | ||
| // being silently swallowed. | ||
| { | ||
| const error = new Error('rejection after callback'); | ||
| process.on('unhandledRejection', common.mustCall((reason) => { | ||
| assert.strictEqual(reason, error); | ||
| })); | ||
| promisify(async (callback) => { | ||
| callback(null, 'value'); | ||
| throw error; | ||
| })().then((value) => assert.strictEqual(value, 'value')).then(common.mustCall()); | ||
| } | ||
|
|
||
| // A returned Promise that fulfills without the callback being called does not | ||
| // settle the result. | ||
| { | ||
| promisify(async () => {})().then(common.mustNotCall('never settling promise expected')); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not validate the message