Repository navigation
sea: add source maps for SEA with VFS - #67503
Merged
Merged
Conversation
Collaborator
|
Review requested:
|
mcollina
force-pushed
the
sea-vfs-sourcemaps
branch
2 times, most recently
from
November 16, 2026 08:59
f3b744e to
ffb2393
Compare
mcollina
marked this pull request as ready for review
November 16, 2026 09:14
mcollina
force-pushed
the
sea-vfs-sourcemaps
branch
from
November 16, 2026 09:40
ffb2393 to
293eb86
Compare
SEA binaries built with "useVfs" can now load source maps from the bundled assets (or the "vfsArchive" archive) and apply them to stack traces and error output, because fs reads are routed through the virtual file system mounted by the SEA. Add two tests covering the inline-assets and zip-archive VFS paths, each asserting that findSourceMap() resolves against the mount point and that a thrown error's frame and source line are remapped to the original source. Also document how to enable and bundle source maps in a SEA. Signed-off-by: Matteo Collina <matteo.collina@gmail.com>
mcollina
force-pushed
the
sea-vfs-sourcemaps
branch
from
November 16, 2026 11:27
293eb86 to
9d786b9
Compare
pipobscure
approved these changes
Nov 16, 2026
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67503 +/- ##
==========================================
- Coverage 90.68% 90.67% -0.01%
==========================================
Files 799 799
Lines 280246 280252 +6
Branches 54113 54128 +15
==========================================
- Hits 254150 254129 -21
- Misses 16234 16242 +8
- Partials 9862 9881 +19 🚀 New features to boost your workflow:
|
aymen94
approved these changes
Nov 16, 2026
Collaborator
jasnell
approved these changes
Nov 18, 2026
Collaborator
|
Landed in 273f217 |
aduh95
pushed a commit
that referenced
this pull request
Nov 19, 2026
SEA binaries built with "useVfs" can now load source maps from the bundled assets (or the "vfsArchive" archive) and apply them to stack traces and error output, because fs reads are routed through the virtual file system mounted by the SEA. Add two tests covering the inline-assets and zip-archive VFS paths, each asserting that findSourceMap() resolves against the mount point and that a thrown error's frame and source line are remapped to the original source. Also document how to enable and bundle source maps in a SEA. Signed-off-by: Matteo Collina <matteo.collina@gmail.com> PR-URL: #67503 Reviewed-By: Philipp Dunkel <pip@pipobscure.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds source-map support for single executable applications built with
"useVfs": true, so.mapfiles and original sources bundled as assets (orin the
"vfsArchive"archive) are read through the virtual file system andapplied to stack traces,
module.findSourceMap(), and the error sourcepreview above an uncaught error.
Adds two tests covering the inline-assets and zip-archive VFS paths, each
asserting that the source map resolves against the mount point and that a
thrown error's frame and source line are remapped to the original source.
Also documents enabling source maps in a SEA and bundling the maps.
AI generated, reviewed by me.