Repository navigation
doc: fix examples that fail as written - #67519
ParhamSaeedNia wants to merge 1 commit into
Conversation
The configuration example set watch-preserve-output in two namespaces, which the parser rejects. Several API samples used the wrong identifier, the wrong Web IDL member, or a value shape the API does not return, so copying them threw or produced the wrong result. The single-executable and duplex iterator pages are already correct on main and are left unchanged. Fixes: nodejs#67518 Assisted-by: a closed-source coding agent Co-authored-by: Parham Saeednia <ParhamSaeedNia@users.noreply.github.com> Signed-off-by: Parham Saeednia <saeedniaparham@gmail.com> Signed-off-by: Parham Saeednia <ParhamSaeedNia@users.noreply.github.com>
|
Review requested:
|
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
|
This would need to be several PRs |
|
Bundling unrelated fixes together, even if it is "only" for documentation, would make it very difficult to review. It could also be that some parts would be accepted, others would need changes and theoretically some changes could be rejected. That needs to be independent. This is the reason for needing several PRs. Please note also that first-time contributors are restricted to one open PR at a time. |
The configuration example set watch-preserve-output in two namespaces, which the parser rejects. Several API samples used the wrong identifier, the wrong Web IDL member, or a value shape the API does not return, so copying them threw or produced the wrong result.
The single-executable and duplex iterator pages are already correct on main and are left unchanged.
Fixes: #67518
Assisted-by: a closed-source coding agent