Repository navigation
Conversation
Walk the file path string up the directory tree instead of parsing a URL for every directory level. Assisted-by: Claude Code Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
araujogui
force-pushed
the
module-package-scope-no-url
branch
from
November 16, 2026 15:44
fecdb85 to
241534e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67523 +/- ##
==========================================
+ Coverage 90.70% 90.72% +0.02%
==========================================
Files 802 801 -1
Lines 282176 280790 -1386
Branches 54379 54206 -173
==========================================
- Hits 255934 254734 -1200
+ Misses 16365 16250 -115
+ Partials 9877 9806 -71
🚀 New features to boost your workflow:
|
Member
Author
|
CC @nodejs/loaders @nodejs/platform-windows |
araujogui
force-pushed
the
module-package-scope-no-url
branch
from
November 17, 2026 14:19
c261f0c to
d295857
Compare
anonrig
reviewed
Nov 18, 2026
ToNamespacedPath() only accepted a BufferValue, so GetPackageScopeConfig() and LegacyMainResolve() copied std::string paths into a V8 string or Buffer just to namespace them on Windows. Use the new overload there instead. Assisted-by: Claude Opus 5.5 Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Walk the file path string up the directory tree instead of parsing a URL for every directory level. Resolves the
TODOinGetPackageScopeConfig.