Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion doc/api/quic.md
Original file line number Diff line number Diff line change
Expand Up @@ -3294,8 +3294,10 @@ added: v23.8.0
-->

* Type: {bigint|number}
* **Default:** `1200`

Specifies the maximum UDP packet payload size.
Specifies the maximum UDP packet payload size. The valid range is `1200` to
`65527`.

#### `sessionOptions.maxStreamWindow`

Expand Down
14 changes: 14 additions & 0 deletions src/quic/session.cc
Original file line number Diff line number Diff line change
Expand Up @@ -629,6 +629,20 @@ Maybe<Session::Options> Session::Options::From(Environment* env,

#undef SET

// ngtcp2 only asserts this range. With assertions compiled out, a value
// below the minimum gives the congestion controller an initial window it
// cannot work with: zero makes it divide by zero as soon as the connection
// is created.
if (options.max_payload_size < NGTCP2_MAX_UDP_PAYLOAD_SIZE ||
options.max_payload_size > NGTCP2_MAX_TX_UDP_PAYLOAD_SIZE) {
THROW_ERR_INVALID_ARG_VALUE(env,
"The maxPayloadSize option must be between "
"%d and %d",
NGTCP2_MAX_UDP_PAYLOAD_SIZE,
NGTCP2_MAX_TX_UDP_PAYLOAD_SIZE);
return Nothing<Options>();
}

// RFC 9000 Section 10.2 requires the draining period to be at least 3x PTO.
static const uint8_t kMinDrainingPeriodMultiplier = 3;
options.draining_period_multiplier = std::max(
Expand Down
17 changes: 16 additions & 1 deletion test/parallel/test-quic-max-payload-size.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// We verify by checking that more packets are needed to transfer
// the same amount of data compared to the default.

import { hasQuic, skip, mustCall } from '../common/index.mjs';
import { hasQuic, skip, mustCall, mustNotCall } from '../common/index.mjs';
import assert from 'node:assert';
import { dump } from 'node:stream/iter';

Expand Down Expand Up @@ -55,3 +55,18 @@ const smallPkts = await transferAndGetPacketCount(1200);
// The key assertion: the option is accepted and data transfers correctly.
assert.ok(defaultPkts > 0n);
assert.ok(smallPkts > 0n);

// Both ends of the supported range work, as a number and as a bigint.
for (const maxPayloadSize of [1200n, 65527, 65527n]) {
assert.ok(await transferAndGetPacketCount(maxPayloadSize) > 0n);
}

// Anything outside of the range is rejected before a session is created.
for (const maxPayloadSize of [0, 0n, 1199, 1199n, 65528, 65528n]) {
const expected = {
code: 'ERR_INVALID_ARG_VALUE',
message: 'The maxPayloadSize option must be between 1200 and 65527',
};
await assert.rejects(listen(mustNotCall(), { maxPayloadSize }), expected);
await assert.rejects(connect('127.0.0.1:1', { maxPayloadSize }), expected);
}
Loading