Repository navigation
test: make test-v8-collect-gc-profile-minor-ms more robust - #67547
Merged
Merged
Conversation
There can be more than one garbage collection triggered by one gc() call and it's not controllable by Node.js. Update the assertion to check that at least one expected GC is there, but don't check that there aren't more. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67547 +/- ##
==========================================
- Coverage 90.69% 90.68% -0.02%
==========================================
Files 801 800 -1
Lines 281875 281081 -794
Branches 54317 54317
==========================================
- Hits 255652 254897 -755
+ Misses 16348 16293 -55
- Partials 9875 9891 +16 🚀 New features to boost your workflow:
|
panva
approved these changes
Nov 17, 2026
lpinca
approved these changes
Nov 17, 2026
Collaborator
jasnell
approved these changes
Nov 18, 2026
Collaborator
|
Landed in ab55d75 |
aduh95
pushed a commit
that referenced
this pull request
Nov 20, 2026
There can be more than one garbage collection triggered by one gc() call and it's not controllable by Node.js. Update the assertion to check that at least one expected GC is there, but don't check that there aren't more. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: #67547 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There can be more than one garbage collection triggered by one gc() call and it's not controllable by Node.js. Update the assertion to check that at least one expected GC is there, but don't check that there aren't more.
Updating it because I ran into a local flake from this