Skip to content

test: make test-v8-collect-gc-profile-minor-ms more robust - #67547

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:fix-test-3
Nov 19, 2026
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:fix-test-3

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

There can be more than one garbage collection triggered by one gc() call and it's not controllable by Node.js. Update the assertion to check that at least one expected GC is there, but don't check that there aren't more.


Updating it because I ran into a local flake from this

AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

  [
    'MinorMarkSweep',
+   'MinorMarkSweep'
  ]

There can be more than one garbage collection triggered by
one gc() call and it's not controllable by Node.js.
Update the assertion to check that at least one expected
GC is there, but don't check that there aren't more.

Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Nov 17, 2026
@codecov

codecov Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.68%. Comparing base (933cb11) to head (cf653fc).
⚠️ Report is 114 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67547      +/-   ##
==========================================
- Coverage   90.69%   90.68%   -0.02%     
==========================================
  Files         801      800       -1     
  Lines      281875   281081     -794     
  Branches    54317    54317              
==========================================
- Hits       255652   254897     -755     
+ Misses      16348    16293      -55     
- Partials     9875     9891      +16     

see 122 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added the flaky-test Issues and PRs involving tests that fail intermittently in CI. label Nov 17, 2026
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 18, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 18, 2026
@nodejs-github-bot

nodejs-github-bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 18, 2026
@jasnell jasnell added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 18, 2026
@nodejs-github-bot
nodejs-github-bot merged commit ab55d75 into nodejs:main Nov 19, 2026
84 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in ab55d75

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 19, 2026
aduh95 pushed a commit that referenced this pull request Nov 20, 2026
There can be more than one garbage collection triggered by
one gc() call and it's not controllable by Node.js.
Update the assertion to check that at least one expected
GC is there, but don't check that there aren't more.

Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #67547
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. flaky-test Issues and PRs involving tests that fail intermittently in CI. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants