Skip to content

tools: avoid swallowing errors in GHA - #67548

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:no-error-swallow
Nov 19, 2026
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:no-error-swallow

Conversation

@aduh95

@aduh95 aduh95 commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

I've noticed in https://github.com/nodejs/node/actions/runs/44119611027/job/134167722190 that the error was not reported.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 17, 2026
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 17, 2026
@nodejs-github-bot
nodejs-github-bot merged commit e25c991 into nodejs:main Nov 19, 2026
38 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in e25c991

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 19, 2026
aduh95 added a commit that referenced this pull request Nov 20, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #67548
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants