Skip to content

lib: legitimize SuppressedError as primordial - #67551

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
LiviaMedeiros:lib-suppressederror-primordial
Nov 21, 2026
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
LiviaMedeiros:lib-suppressederror-primordial

Conversation

@LiviaMedeiros

@LiviaMedeiros LiviaMedeiros commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

SuppressedError is a part of ERM which is fully unflagged on v27.x+

@LiviaMedeiros LiviaMedeiros added blocked PRs that are blocked by other issues or PRs. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. labels Nov 17, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic
  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC transport implementation. stream Issues and PRs related to Node.js streams. labels Nov 17, 2026
@codecov

codecov Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.60%. Comparing base (915cf10) to head (1d53bc1).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67551      +/-   ##
==========================================
- Coverage   90.60%   90.60%   -0.01%     
==========================================
  Files         801      801              
  Lines      281036   281035       -1     
  Branches    54252    54237      -15     
==========================================
- Hits       254640   254630      -10     
  Misses      16577    16577              
- Partials     9819     9828       +9     
Files with missing lines Coverage Δ
lib/internal/quic/quic.js 100.00% <100.00%> (ø)
lib/internal/streams/iter/consumers.js 97.47% <100.00%> (+0.14%) ⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: LiviaMedeiros <livia@cirno.name>
@LiviaMedeiros LiviaMedeiros removed the blocked PRs that are blocked by other issues or PRs. label Nov 21, 2026
@LiviaMedeiros
LiviaMedeiros force-pushed the lib-suppressederror-primordial branch from bd8c1f2 to 1d53bc1 Compare November 21, 2026 15:08
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@gurgunday gurgunday left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LiviaMedeiros LiviaMedeiros added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 21, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 2b365b2 into nodejs:main Nov 21, 2026
65 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 2b365b2

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC transport implementation. stream Issues and PRs related to Node.js streams.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants