Skip to content

doc: fix SEA implementation link in maintaining guide - #67555

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
farisbasha:doc-sea-embedding-link
Nov 19, 2026
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
farisbasha:doc-sea-embedding-link

Conversation

@farisbasha

Copy link
Copy Markdown
Contributor

The single executable application maintaining guide (doc/contributing/maintaining/maintaining-single-executable-application-support.md, "Implementation") says the SEA blob is passed to lib/internal/main/single_executable_application.js. That file no longer exists (the link is a 404); SEA main scripts now run through lib/internal/main/embedding.js ("src: share common code paths for SEA and embedder script"). This updates the sentence and the link.

AI disclosure: a coding assistant found the dead link and drafted this change. Verification: the old path returns 404, and lib/internal/main/embedding.js handles the SEA case (isSea(), "It's a single-executable application loading a main script").

lib/internal/main/single_executable_application.js no longer exists;
single executable applications now run their main script through
lib/internal/main/embedding.js. Point the guide at that file.

Signed-off-by: farisbasha <farisbashatm@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/single-executable
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Nov 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

Caution

AgentScan found account activity patterns that may be consistent with automation. This is a heuristic, not proof that this pull request was opened by an agent or violates policy. AI-assisted contributions are permitted, but automated tooling must not open pull requests without advance approval, and contributors must personally understand, test, verify, and take responsibility for every submitted change. See the AgentScan analysis, AI use policy, and automation policy for additional context.

@MikeMcC399 MikeMcC399 added the single-executable Issues and PRs related to single-executable applications. label Nov 17, 2026

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 18, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 108cbef into nodejs:main Nov 19, 2026
30 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 108cbef

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 19, 2026
aduh95 pushed a commit that referenced this pull request Nov 20, 2026
lib/internal/main/single_executable_application.js no longer exists;
single executable applications now run their main script through
lib/internal/main/embedding.js. Point the guide at that file.

Signed-off-by: farisbasha <farisbashatm@gmail.com>
PR-URL: #67555
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agentscan:automated-account doc Issues and PRs related to Node.js documentation. single-executable Issues and PRs related to single-executable applications.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants