Skip to content

quic: honor enableEarlyData on servers - #67562

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
efekrskl:quic/fix-early-data-disabled
Nov 20, 2026
Merged

nodejs-github-bot merged 2 commits into
nodejs:mainfrom
efekrskl:quic/fix-early-data-disabled

Conversation

@efekrskl

Copy link
Copy Markdown
Member

enableEarlyData: false was overwritten while configuring each server TLS session.

Pass the option to OpenSSL and add regression coverage using a ticket issued and reused by the same endpoint.

Signed-off-by: Efe Karasakal <hi@efe.dev>
Signed-off-by: Efe Karasakal <hi@efe.dev>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC transport implementation. labels Nov 17, 2026
@codecov

codecov Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.72%. Comparing base (2231574) to head (45a3501).
⚠️ Report is 67 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67562      +/-   ##
==========================================
- Coverage   90.73%   90.72%   -0.01%     
==========================================
  Files         801      801              
  Lines      280705   280705              
  Branches    54167    54175       +8     
==========================================
- Hits       254686   254669      -17     
+ Misses      16210    16208       -2     
- Partials     9809     9828      +19     

see 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasnell jasnell moved this to Ready for Review in QUIC Team Nov 18, 2026
Comment thread src/quic/tlscontext.cc Resolved
@pimterry pimterry added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 18, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 18, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@efekrskl efekrskl added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 19, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 19, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Commit Queue failed

This pull request has multiple commits, but no landing policy was selected.

Add commit-queue-squash PRs the Commit Queue should land as one squashed commit. to land it as one commit, or commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. to land the commits separately.

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output
�[36m⠋�[39m Loading data for nodejs/node/pull/67562
�[36m⠋�[39m Loading data for nodejs/node/pull/67562
�[36m⠋�[39m Getting collaborator contacts from README of nodejs/node
�[36m⠋�[39m Getting PR from nodejs/node/pull/67562
�[36m⠋�[39m Getting reviews from nodejs/node/pull/67562
�[36m⠋�[39m Getting comments from nodejs/node/pull/67562
�[36m⠋�[39m Getting commits from nodejs/node/pull/67562
✔  Done loading data for nodejs/node/pull/67562
----------------------------------- PR info ------------------------------------
Title      quic: honor enableEarlyData on servers (#67562)
   ⚠  Could not retrieve the email or name of the PR's author from user's GitHub profile!
Branch     efekrskl:quic/fix-early-data-disabled -> nodejs:main
Labels     c++, needs-ci, quic, commit-queue
Commits    2
 - quic: honor enableEarlyData on servers
 - quic: fmt
Committers 1
 - Efe Karasakal <hi@efe.dev>
PR-URL: https://github.com/nodejs/node/pull/67562
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/67562
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 17 Nov 2026 21:28:55 GMT
   ✔  Approvals: 2
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/67562#pullrequestreview-5956770028
   ✔  - Tim Perry (@pimterry): https://github.com/nodejs/node/pull/67562#pullrequestreview-5961489397
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-11-18T17:45:38Z: https://ci.nodejs.org/job/node-test-pull-request/79273/
�[36m⠙�[39m Querying data for job/node-test-pull-request/79273/
�[36m⠙�[39m Querying data for job/node-test-pull-request/79273/
�[36m⠙�[39m Querying API for job/node-test-pull-request/79273/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
�[36m⠹�[39m Bringing origin/main up to date...
�[36m⠹�[39m Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
�[36m⠸�[39m Downloading patch for 67562
�[36m⠸�[39m Downloading patch for 67562
From https://github.com/nodejs/node
 * branch                  refs/pull/67562/merge -> FETCH_HEAD
✔  Fetched commits as 029acbfbd7e9..45a350122177
--------------------------------------------------------------------------------
[main fc1877fe7b] quic: honor enableEarlyData on servers
 Author: Efe Karasakal <hi@efe.dev>
 Date: Tue Nov 17 22:24:10 2026 +0100
 3 files changed, 118 insertions(+), 75 deletions(-)
[main f5712030de] quic: fmt
 Author: Efe Karasakal <hi@efe.dev>
 Date: Tue Nov 17 22:24:36 2026 +0100
 1 file changed, 2 insertions(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
(node:392) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
(Use `node --trace-deprecation ...` to show where the warning was created)
Rebasing (2/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
quic: honor enableEarlyData on servers

Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: https://github.com/nodejs/node/pull/67562
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD 9ca62ff86f] quic: honor enableEarlyData on servers
 Author: Efe Karasakal <hi@efe.dev>
 Date: Tue Nov 17 22:24:10 2026 +0100
 3 files changed, 118 insertions(+), 75 deletions(-)
Rebasing (3/4)
Rebasing (4/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
quic: fmt

Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: https://github.com/nodejs/node/pull/67562
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD 8869b8b8a0] quic: fmt
 Author: Efe Karasakal <hi@efe.dev>
 Date: Tue Nov 17 22:24:36 2026 +0100
 1 file changed, 2 insertions(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.
--------------------------------------------------------------------------------
   ℹ  Add `commit-queue-squash` label to land the PR as one commit, or `commit-queue-rebase` to land as separate commits.

View workflow run

@efekrskl efekrskl added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Nov 20, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 5884b8e into nodejs:main Nov 20, 2026
93 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 5884b8e

@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in QUIC Team Nov 20, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 20, 2026
aduh95 pushed a commit that referenced this pull request Nov 20, 2026
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #67562
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC transport implementation.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants