Repository navigation
test: prefer common/tmpdir over os.tmpdir() - #67567
Merged
nodejs-github-bot merged 3 commits intoNov 20, 2026
Merged
Conversation
Signed-off-by: LiviaMedeiros <livia@cirno.name>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67567 +/- ##
==========================================
- Coverage 90.71% 90.71% -0.01%
==========================================
Files 801 801
Lines 280705 280794 +89
Branches 54168 54195 +27
==========================================
+ Hits 254640 254711 +71
- Misses 16247 16248 +1
- Partials 9818 9835 +17 🚀 New features to boost your workflow:
|
jasnell
approved these changes
Nov 18, 2026
This comment was marked as outdated.
This comment was marked as outdated.
panva
approved these changes
Nov 18, 2026
cjihrig
approved these changes
Nov 18, 2026
lpinca
approved these changes
Nov 18, 2026
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: LiviaMedeiros <livia@cirno.name>
Collaborator
Collaborator
|
Landed in 0482448 |
aduh95
pushed a commit
that referenced
this pull request
Nov 20, 2026
Signed-off-by: LiviaMedeiros <livia@cirno.name> PR-URL: #67567 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should avoid using OS's tmpdir in tests when possible. This PR:
Temporary filespart to the writing tests guide, makingcommon/tmpdirmore visible and explicitly recommendedos.tmpdir()usageAny suggestions on improving the lint rule are welcome. It's not panacea and my vision of follow-up is vague for now, but i think it would be feasible to add
mkdtemp/mkstemp-alike sugar tocommon/tmpdir.