Repository navigation
zlib: fix crash when async buffers are detached or resized - #67603
Open
ShogunPanda wants to merge 1 commit into
Open
ShogunPanda wants to merge 1 commit into
ShogunPanda wants to merge 1 commit into
Conversation
Asynchronous zlib, brotli and zstd operations run on the libuv threadpool, where the worker thread reads and writes through raw pointers into JavaScript-owned backing stores. Detaching or resizing the input or output ArrayBuffer while the operation is in flight frees or decommits the backing store the worker is still accessing, which crashes the process. Pin non-resizable input and output buffers with a std::shared_ptr<v8::BackingStore> for the duration of the operation, and copy resizable buffers into engine-owned memory because resize() decommits pages even when a backing store is pinned. Surface the resulting "buffer invalidated" errors as stream errors rather than uncaught exceptions. Assisted-By: OpenAI GPT-5.6 Sol <openai/gpt-5.6-sol> Signed-off-by: Matteo Collina <hello@matteocollina.com> Signed-off-by: Paolo Insogna <paolo@cowtech.it>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67603 +/- ##
==========================================
- Coverage 90.73% 90.70% -0.03%
==========================================
Files 801 801
Lines 280794 280869 +75
Branches 54202 54218 +16
==========================================
- Hits 254771 254757 -14
- Misses 16202 16268 +66
- Partials 9821 9844 +23
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asynchronous zlib, brotli and zstd operations run on the libuv threadpool, where the worker thread accesses JavaScript-owned backing stores through raw pointers. If the input or output
ArrayBufferis detached (for example withArrayBuffer.prototype.transfer()or a transferredpostMessage()) or resized (ArrayBuffer.prototype.resize()) while the operation is in flight, the worker reads or writes invalid memory and the process crashes.Non-resizable input and output buffers are now pinned with a
std::shared_ptr<v8::BackingStore>for the duration of the operation, and resizable buffers are copied into engine-owned memory, becauseresize()decommits pages even when a backing store is pinned. The resulting "buffer invalidated" errors are surfaced as stream errors rather than uncaught exceptions. The documentation now states that these buffers must not be detached or resized until the operation completes.