Repository navigation
tls: destroy socket when newSession listener throws - #67605
Open
ShogunPanda wants to merge 1 commit into
Open
ShogunPanda wants to merge 1 commit into
ShogunPanda wants to merge 1 commit into
Conversation
Route exceptions thrown by `newSession` listeners to `socket.destroy(err)`, like the other handshake callback guards, instead of re-emitting them on the server. Update the regression test to run without a server `error` listener. Assisted-By: OpenAI GPT-5.6 Sol <openai/gpt-5.6-sol> Signed-off-by: Paolo Insogna <paolo@cowtech.it>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67605 +/- ##
==========================================
- Coverage 90.73% 90.71% -0.02%
==========================================
Files 801 801
Lines 280794 280809 +15
Branches 54202 54211 +9
==========================================
- Hits 254771 254733 -38
- Misses 16202 16252 +50
- Partials 9821 9824 +3
🚀 New features to boost your workflow:
|
pimterry
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
newSessionlistener on atls.Serverthrows, the guard inonnewsessionre-emits the exception as an'error'event on the server instead of destroying the socket, unlike the other handshake callback guards (SNICallback,resumeSession,OCSPRequest). A server without an'error'listener then rethrows it from inside the callback.The exception is now routed to
socket.destroy(err). The regression test no longer registers a server'error'listener, and checks that the server-side socket is destroyed with the original error.AI-assisted work. All changes reviewed by a human.